From: Junio C Hamano <gitster@pobox.com>
To: Alexandre Julliard <julliard@winehq.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] checkout: Don't crash when switching away from an invalid branch.
Date: Fri, 07 Nov 2008 15:06:18 -0800 [thread overview]
Message-ID: <7vbpwrf85x.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <87od0r9nnj.fsf@wine.dyndns.org> (Alexandre Julliard's message of "Fri, 07 Nov 2008 23:28:16 +0100")
Alexandre Julliard <julliard@winehq.org> writes:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> ...
>> Why not
>> old_desc ? old_desc : "(invalid)"
>> ?
>
> IMO it looks more friendly to not display a branch that doesn't exist,
> rather than printing something like (invalid) or (null).
Actually I think it is a good idea to remind that you were in a funny
state.
For that matter, dying without removing the trace of that funny state
might be even preferrable if you need to do postmortem to figure out why
you got into such a funny state to begin with, but not everybody uses git
to debug git. I think Dscho's suggestion is a reasonable middle ground.
next prev parent reply other threads:[~2008-11-07 23:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 17:02 [PATCH] checkout: Don't crash when switching away from an invalid branch Alexandre Julliard
2008-11-07 18:05 ` Johannes Schindelin
2008-11-07 22:28 ` Alexandre Julliard
2008-11-07 23:06 ` Junio C Hamano [this message]
2008-11-08 10:07 ` Alexandre Julliard
-- strict thread matches above, loose matches on Subject: below --
2008-11-08 12:03 Alexandre Julliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbpwrf85x.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=julliard@winehq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox