From: Junio C Hamano <gitster@pobox.com>
To: "David Kågedal" <davidk@lysator.liu.se>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Don't fail when an existing directory can't be created.
Date: Fri, 22 Aug 2008 15:35:22 -0700 [thread overview]
Message-ID: <7vbpzk7k5x.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <87pro1pj3l.fsf@lysator.liu.se> (David Kågedal's message of "Fri, 22 Aug 2008 10:08:46 +0200")
David Kågedal <davidk@lysator.liu.se> writes:
> This makes it possible to install in a writable directory not owned by
> the current user.
> ---
Sign-off?
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 7a2130a..e6271d8 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -87,15 +87,15 @@ man7: $(DOC_MAN7)
> info: git.info gitman.info
>
> install: man
> - $(INSTALL) -d -m 755 $(DESTDIR)$(man1dir)
> - $(INSTALL) -d -m 755 $(DESTDIR)$(man5dir)
> - $(INSTALL) -d -m 755 $(DESTDIR)$(man7dir)
> + -$(INSTALL) -d -m 755 $(DESTDIR)$(man1dir)
> + -$(INSTALL) -d -m 755 $(DESTDIR)$(man5dir)
> + -$(INSTALL) -d -m 755 $(DESTDIR)$(man7dir)
Makes me wonder what happens if you failed to create the target
directory. Is it deemed to be Ok because the later step of installing the
contents will fail anyway?
next prev parent reply other threads:[~2008-08-22 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 8:08 [PATCH] Don't fail when an existing directory can't be created David Kågedal
2008-08-22 22:35 ` Junio C Hamano [this message]
2008-08-23 14:29 ` David Kågedal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbpzk7k5x.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=davidk@lysator.liu.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).