From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] checkout --track: make up a sensible branch name if '-b' was omitted
Date: Mon, 11 Aug 2008 11:54:08 -0700 [thread overview]
Message-ID: <7vbpzzxu0f.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0808111256260.24820@pacific.mpi-cbg.de.mpi-cbg.de> (Johannes Schindelin's message of "Mon, 11 Aug 2008 13:01:40 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Don't get me wrong. I do not need that patch in git.git desperately.
> But if it is rejected, I want it to be rejected for reasons I understand.
You are the second person in the past few days to talk about rejection
after my comments. I'll try to do better in the future, but if it was not
clear, I thought the original is good enough for inclusion as-is.
My comments were about potential improvements on top of what was
presented, and I say "potential" not in the sense that yours is inferior
than the ideal because it lacks such improvements, but in the sense that
the suggested line of thought might not be even an improvement (iow, I do
not mean "the code your patch brings is has potential to improve and not
good enough as it stands", but "I think we might also want to do these on
top of it, but I may well have overlooked downsides in my suggestion hence
I am bringing it up for discussion").
next prev parent reply other threads:[~2008-08-11 18:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-09 14:00 [PATCH] checkout --track: make up a sensible branch name if '-b' was omitted Johannes Schindelin
2008-08-09 18:44 ` Junio C Hamano
2008-08-09 19:46 ` Junio C Hamano
2008-08-09 21:08 ` Johannes Schindelin
2008-08-09 21:11 ` Junio C Hamano
2008-08-09 21:44 ` Pieter de Bie
2008-08-10 23:02 ` Johannes Schindelin
2008-08-11 11:01 ` Johannes Schindelin
2008-08-11 18:54 ` Junio C Hamano [this message]
2008-08-09 21:56 ` Tarmigan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbpzzxu0f.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).