From: Junio C Hamano <gitster@pobox.com>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: "Peter Valdemar Mørch (Lists)" <4ux6as402@sneakemail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Document disabling core.whitespace values trailing-space and space-before-tab
Date: Thu, 24 Jul 2008 21:44:47 -0700 [thread overview]
Message-ID: <7vbq0m608w.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080724172912.6117@nanako3.lavabit.com> (Nanako Shiraishi's message of "Thu, 24 Jul 2008 17:29:12 +0900")
Nanako Shiraishi <nanako3@lavabit.com> writes:
> Quoting "Peter Valdemar Mrch (Lists)" <4ux6as402@sneakemail.com>:
>
>> The '-trailing-space' syntax to disable the trailing-space setting is
>> not obvious and not documented as far as I can see. I would have
>> assumed a value of '' would disable it.
>>
>> Is there a documentation bug here? If so, I suggest this patch. I
>> didn't find anywhere else where the '-setting' syntax was used to
>> disable something.
>
> Doesn't gitattributes(5) describe the overall syntax in detail?
Yes, but as Peter says in his reply to you, it only talks about [-!]name
syntax to force the variable to unset (with '-' prefix) and to revert the
variable to the unspecified state (with '!' prefix).
Various "values" given to the whitespace attribute actually act as if they
are sub-variables and obey the similar "[-]name" rule, but (1) that is
left unsaid, and (2) in that context '!' does not make sense so only '-'
has any meaning. We would certainly need to clarify that.
So I think Peter's patch is going in the right direction.
next prev parent reply other threads:[~2008-07-25 4:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 5:34 [PATCH] Document disabling core.whitespace values trailing-space and space-before-tab "Peter Valdemar Mørch (Lists)"
2008-07-24 8:29 ` Nanako Shiraishi
2008-07-24 9:41 ` "Peter Valdemar Mørch (Lists)"
2008-07-25 4:44 ` Junio C Hamano [this message]
2008-07-25 6:11 ` Peter Valdemar Mørch
2008-07-25 6:13 ` "Peter Valdemar Mørch (Lists)"
2008-07-25 8:49 ` Junio C Hamano
2008-07-25 7:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbq0m608w.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=4ux6as402@sneakemail.com \
--cc=git@vger.kernel.org \
--cc=nanako3@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).