git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Avery Pennarun" <apenwarr@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Eduard - Gabriel Munteanu" <eduard.munteanu@linux360.ro>,
	ryan@michonline.com, git@vger.kernel.org
Subject: Re: [PATCH] Added --export option to git-send-email.
Date: Sun, 13 Jul 2008 14:36:08 -0700	[thread overview]
Message-ID: <7vbq11qxfb.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <32541b130807131432j78e5100dyea20893268321466@mail.gmail.com> (Avery Pennarun's message of "Sun, 13 Jul 2008 17:32:57 -0400")

"Avery Pennarun" <apenwarr@gmail.com> writes:

> On 7/13/08, Junio C Hamano <gitster@pobox.com> wrote:
>> Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> writes:
>>  > +     } elsif (defined $export_file) {
>>  > +             my $mbox_from = "From $raw_from $date";
>>  > +             $message =~ s/^(>{0,})From/>$1From/m;
>>  > +             print $out "$mbox_from\n$header\n$message";
>>
>> Sorry, but I am scratching my head here.  Shouldn't this "bare From
>>  munging" be like this instead?
>>
>>                 $message =~ s/^From />From /m;
>
> That wouldn't be a reversible operation.

So what?  Adding Cc: and stuff send-email does are already irreversible
anyway.

  reply	other threads:[~2008-07-13 21:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-10 14:07 [PATCH] Added --export option to git-send-email Eduard - Gabriel Munteanu
2008-07-11  7:03 ` Junio C Hamano
2008-07-11 19:53   ` Eduard - Gabriel Munteanu
2008-07-13 20:17 ` Junio C Hamano
2008-07-13 21:32   ` Avery Pennarun
2008-07-13 21:36     ` Junio C Hamano [this message]
2008-07-13 21:44       ` Avery Pennarun
2008-07-13 22:05         ` Junio C Hamano
2008-07-13 22:21           ` Avery Pennarun
2008-07-13 22:44             ` Junio C Hamano
2008-07-13 23:42               ` Avery Pennarun
2008-07-13 23:58                 ` Eduard - Gabriel Munteanu
2008-07-14  3:13                 ` Junio C Hamano
2008-07-14  3:41                   ` Avery Pennarun
2008-07-14  0:05               ` Eduard - Gabriel Munteanu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbq11qxfb.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=apenwarr@gmail.com \
    --cc=eduard.munteanu@linux360.ro \
    --cc=git@vger.kernel.org \
    --cc=ryan@michonline.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).