From: Junio C Hamano <gitster@pobox.com>
To: "Santi Béjar" <sbejar@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] Show committer ident in some cases
Date: Fri, 02 May 2008 15:32:39 -0700 [thread overview]
Message-ID: <7vbq3owd4o.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <8aa486160805021507s44d7946ejc48ac8a4af08e8cc@mail.gmail.com> (Santi Béjar's message of "Sat, 3 May 2008 00:07:44 +0200")
"Santi Béjar" <sbejar@gmail.com> writes:
> On Fri, May 2, 2008 at 11:44 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Santi Béjar <sbejar@gmail.com> writes:
>>
>> > The definition of "wrong committer" could be:
>> >
>> > 1) user.{name,email} or GIT_COMMITTER_{NAME,EMAIL} is not a wrong committer.
>> > 2) automatic without a domain name (user@hostname.(none)) is a wrong committer.
>> > (not handled with this patch series)
>> > 3) automatic or partially set ident:
>> > a) wrong committer for some users
>> > b) right committer for others
>>
>> Define "partially set".
>
> one of user.{name,email} is not set.
Hmmm. Then perhaps the list can be simplified as follows?
* Both name and email are explicitly given (i.e. user.* or
GIT_COMMITTER_* specifies them) --- no complaints.
* For email, ending with ".(none)" and "@" followed by something without
a dot is wrong but everything else are Ok.
* Everything else falls into (3)
There is no "partially" then.
By the way, wasn't it you who wanted to refuse use of user.name _and_
user.email that come from ~/.gitconfig, so that you can be sure you use
different pseudonym for each project?
next prev parent reply other threads:[~2008-05-02 22:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 18:22 [PATCH 0/2] Show committer ident in some cases Santi Béjar
2008-05-02 18:22 ` [PATCH 1/2] commit: Show committer if automatic Santi Béjar
2008-05-03 18:33 ` Junio C Hamano
2008-05-03 20:28 ` Santi Béjar
2008-05-02 18:22 ` [PATCH 2/2] user.warnautomatic: add config to control if the committer ident is shown Santi Béjar
2008-05-02 21:44 ` [PATCH 0/2] Show committer ident in some cases Junio C Hamano
2008-05-02 22:07 ` Santi Béjar
2008-05-02 22:32 ` Junio C Hamano [this message]
2008-05-03 10:18 ` Santi Béjar
2008-05-05 3:30 ` Jeff King
2008-05-05 5:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbq3owd4o.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sbejar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).