From: Junio C Hamano <gitster@pobox.com>
To: Dan McGee <dpmcgee@gmail.com>
Cc: git@vger.kernel.org, B.Steinbrink@gmx.de, gitster@pobox.com
Subject: Re: [PATCH resubmit] Allow cherry-pick (and revert) to add signoff line
Date: Sat, 26 Apr 2008 14:07:49 -0700 [thread overview]
Message-ID: <7vbq3wmije.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1209240868-30815-1-git-send-email-dpmcgee@gmail.com> (Dan McGee's message of "Sat, 26 Apr 2008 15:14:28 -0500")
Dan McGee <dpmcgee@gmail.com> writes:
> +-s|--signoff::
> + Add Signed-off-by line at the end of the commit message.
> +
Good.
> + OPT_BOOLEAN('s', "signoff", &signoff, "add Signed-off-by: header"),
Not so good ;-)
Will apply with an obvious "s/by: header/by:/" and merge to 'next'.
Thanks.
next prev parent reply other threads:[~2008-04-26 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-20 18:03 [PATCH] Allow cherry-pick (and revert) to add signoff line Dan McGee
2008-04-20 18:28 ` Björn Steinbrink
2008-04-23 5:08 ` Junio C Hamano
2008-04-26 14:46 ` Dan McGee
2008-04-26 20:14 ` [PATCH resubmit] " Dan McGee
2008-04-26 21:07 ` Junio C Hamano [this message]
2008-04-27 0:43 ` [PATCH] Remove 'header' from --signoff option description Dan McGee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbq3wmije.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=B.Steinbrink@gmx.de \
--cc=dpmcgee@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).