git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Santi Béjar" <sbejar@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	git@vger.kernel.org
Subject: Re: [PATCH] Teach git-describe --long to output always the long format
Date: Mon, 25 Feb 2008 00:54:21 -0800	[thread overview]
Message-ID: <7vbq65ju0y.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <8aa486160802250034ncdf20b6s13856ca8612bc2ea@mail.gmail.com> (Santi Béjar's message of "Mon, 25 Feb 2008 09:34:31 +0100")

"Santi Béjar" <sbejar@gmail.com> writes:

> On Mon, Feb 25, 2008 at 4:08 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> "Shawn O. Pearce" <spearce@spearce.org> writes:
>> ...
>>  > Is this really that useful?  Where is having the tag and the commit
>>  > SHA-1 both useful?
>>
>>  I had the same question.  The only place that I find this could
>>  be useful is when you tag, build and install, and then find
>>  glitches before pushing the results out and rewind, rebuild and
>>  re-tag.  I unfortunately have this issue almost all the time.
>>
>>  But even then, I would probably not rely on this patch.
>
> This can be usefull when more than one person can make "official" tags
> (or nobody), and then you have a uniqe idendifier with a descriptive
> name.

That's backwards.  If you want reliable unique identifier, you
would use 40-hexdigit.  If you want human readable, you would
use tags, and if you allow different people to distribute tags
with the same name that point at different things, _you_ have a
problem at higher level.

By the way, I think the naming "git describe" does is not quite
right.  The name of the tag _usually_ matches its path under
refs/tags/ by convention, but the code seems to trust the path
and does not seem to examine what the actual tag name in the
annotated tag is.

I think it should name commits based on the real tag name, at
least when it is only using annotated tags (i.e. the default
mode of operation).

  reply	other threads:[~2008-02-25  8:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-24 14:46 [PATCH] Teach git-describe --long to output always the long format Santi Béjar
2008-02-25  2:36 ` Shawn O. Pearce
2008-02-25  3:08   ` Junio C Hamano
2008-02-25  8:34     ` Santi Béjar
2008-02-25  8:54       ` Junio C Hamano [this message]
2008-02-25  9:05         ` Santi Béjar
2008-02-25 20:11           ` Junio C Hamano
2008-02-25 20:51             ` Santi Béjar
2008-02-26  9:19               ` Junio C Hamano
2008-02-26  9:41                 ` Santi Béjar
2008-02-25  8:50     ` Jakub Narebski
2008-02-25  9:43 ` Santi Béjar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbq65ju0y.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sbejar@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).