git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Grégoire Barbier" <gb@gbarbier.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] http-push: making HTTP push more robust and more user-friendly
Date: Sun, 13 Jan 2008 15:01:10 -0800	[thread overview]
Message-ID: <7vbq7ppbyh.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1200250979-19604-1-git-send-email-gb@gbarbier.org> (Grégoire Barbier's message of "Sun, 13 Jan 2008 20:02:57 +0100")

Grégoire Barbier <gb@gbarbier.org> writes:

> Fail when info/refs exists and is already locked (avoiding strange behaviour
> and errors, and maybe avoiding some repository corruption).
>
> Warn if the URL does not end with '/' (since 302 is not yet handled)
>
> More explicit error message when the URL or password is not set correctly
> (instead of "no DAV locking support").
>
> DAV locking time of 1 minute instead of 10 minutes (avoid waiting 10 minutes
> for a orphan lock to expire before anyone can do a push on the repo).

I do not remember these discussed on the list, and would like to
see people who do use http-push to comment on these.  Especially
because there is no correct timeout that is good for everybody,
the last item might be contentious.

The second one to add a couple of "goto cleanup" looked
correct.  Acks, people?

Also http-push being unusable without CURL_MULTI was also a news
to me.  Is this something that came up on #git perhaps?

This change means people need curl 7.10 or newer (post May 2003,
that is).  I do not think it is too new a version to require,
but then it makes me wonder if it makes much sense for us to
keep supporting non CURL_MULTI build these days.  Perhaps we
should schedule such a move to drop non MULTI build in the
future?

  parent reply	other threads:[~2008-01-13 23:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-13 19:02 [PATCH] http-push: making HTTP push more robust and more user-friendly Grégoire Barbier
2008-01-13 19:02 ` [PATCH] http-push: fix webdav lock leak Grégoire Barbier
2008-01-13 19:02   ` [PATCH] http-push: disable http-push without USE_CURL_MULTI Grégoire Barbier
2008-01-13 23:01 ` Junio C Hamano [this message]
2008-01-14 11:21   ` [PATCH] http-push: making HTTP push more robust and more user-friendly Johannes Schindelin
2008-01-14 19:35     ` Junio C Hamano
2008-01-14 20:22       ` Johannes Schindelin
2008-01-19 15:21   ` Grégoire Barbier
2008-01-19 23:18     ` Johannes Schindelin
2008-01-21 10:09   ` Grégoire Barbier
2008-01-21 10:20     ` Junio C Hamano
2008-01-21 10:27       ` Grégoire Barbier
2008-01-21 11:06         ` Junio C Hamano
2008-01-21 12:17           ` Johannes Schindelin
2008-01-21 20:18             ` Junio C Hamano
2008-01-21 20:29               ` Mike Hommey
2008-01-22  0:58                 ` Johannes Schindelin
2008-01-22  1:34                   ` Junio C Hamano
2008-01-22  1:38                     ` Johannes Schindelin
2008-01-22  2:04                       ` Junio C Hamano
2008-01-22  2:14                         ` Johannes Schindelin
2008-01-21 21:30               ` Daniel Barkalow
2008-01-21 22:05                 ` Junio C Hamano
2008-01-21 23:12                   ` Grégoire Barbier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbq7ppbyh.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=gb@gbarbier.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).