From: Junio C Hamano <gitster@pobox.com>
To: "Stephen Sinclair" <radarsat1@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add committer and author names to top of COMMIT_EDITMSG.
Date: Fri, 11 Jan 2008 16:22:23 -0800 [thread overview]
Message-ID: <7vbq7r28qo.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <9b3e2dc20801111609t3103af1frc23519cab43ae8be@mail.gmail.com> (Stephen Sinclair's message of "Fri, 11 Jan 2008 19:09:23 -0500")
"Stephen Sinclair" <radarsat1@gmail.com> writes:
>> I'd almost agree with this patch if if added AUTHOR but not
>> COMMITTER, and only when AUTHOR is different from me. That
>> would help reassure anybody while amending other's changes.
>> COMMITTER is always me and I should not reminded with extra
>> lines that waste precious screen real estate.
>
> The purpose of my patch was to remind _myself_ what my name is, in
> case I hadn't configured it correctly.
In that case, I would imagine a rule like this would be more
appropriate than unconditionally showing AUTHOR/COMMITTER in all
cases:
* If AUTHOR_NAME+EMAIL is different from AUTHOR_NAME+EMAIL that
I would normally get for myself, or
* If AUTHOR_NAME+EMAIL contains garbage identifier commonly
found when misconfigured (e.g. ".(none)" at the end of
e-mail),
then show AUTHOR. In addition, if it is the latter case, give
hints to configure before casting the mistake in stone.
next prev parent reply other threads:[~2008-01-12 0:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 20:10 [PATCH] Add committer and author names to top of COMMIT_EDITMSG Stephen Sinclair
2008-01-11 21:26 ` Johannes Schindelin
2008-01-11 23:36 ` Junio C Hamano
2008-01-12 0:09 ` Stephen Sinclair
2008-01-12 0:22 ` Junio C Hamano [this message]
2008-01-12 1:33 ` Stephen Sinclair
2008-01-12 1:53 ` Junio C Hamano
2008-01-12 2:25 ` Stephen Sinclair
2008-01-12 4:57 ` Junio C Hamano
2008-01-12 7:26 ` Stephen Sinclair
2008-01-12 8:02 ` Junio C Hamano
2008-01-12 4:52 ` Jeff King
2008-01-12 5:06 ` Junio C Hamano
2008-01-12 5:30 ` Junio C Hamano
2008-01-12 5:32 ` Jeff King
2008-01-12 5:56 ` Junio C Hamano
2008-01-12 5:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbq7r28qo.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=radarsat1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).