From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Fix random sha1 in error message in http-fetch and http-push
Date: Fri, 14 Dec 2007 14:17:53 -0800 [thread overview]
Message-ID: <7vbq8sq5ta.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1197667081-9909-2-git-send-email-mh@glandium.org> (Mike Hommey's message of "Fri, 14 Dec 2007 22:18:01 +0100")
Mike Hommey <mh@glandium.org> writes:
> Please note that this is already fixed in my strbuf patch for these files,
> which had been applied in pu, but it seems to have disappeared from pu's
> history. This also means the strbuf patch conflicts with this one. Please
> tell me if you want a new strbuf patch made after this one.
The branch 'pu' almost always rewind and gets rebuilt from the tip of
'next'. Since I am more worried about master and next, even more so
than usual these days, most of the backburnered topics are not even in
'pu' but I still keep tips of them not to lose (they are found in
'offcuts').
Give me a few days to get back to your series. I think it is a series
of good clean-up patches, (I just read [1/2] which was trivially correct
although I am not sure if it is the optimum fix to sprinkle free(url) to
everywhere we have return), but I just haven't got around to them.
prev parent reply other threads:[~2007-12-14 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 21:18 [PATCH 1/2] Fix some more memory leaks in http-push.c Mike Hommey
2007-12-14 21:18 ` [PATCH 2/2] Fix random sha1 in error message in http-fetch and http-push Mike Hommey
2007-12-14 22:17 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbq8sq5ta.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).