From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Brian Downing <bdowning@lavos.net>,
Steffen Prohaska <prohaska@zib.de>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Corrupted (?) commit 6e6db85e confusing gitk
Date: Sun, 02 Dec 2007 14:36:10 -0800 [thread overview]
Message-ID: <7vbq98u3l1.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.0.9999.0712021348020.8458@woody.linux-foundation.org> (Linus Torvalds's message of "Sun, 2 Dec 2007 13:49:40 -0800 (PST)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Sun, 2 Dec 2007, Johannes Schindelin wrote:
>>
>> Darn. But when can "GIT_AUTHOR_DATE" be set to the empty string? I mean,
>> I understand unset'ing it. But setting it to ""?
>
> Well, regardless, I think we should make sure that git-commit-tree never
> writes out an invalid commit - no matter *how* insane input it gets.
> Making it complain loudly (with a 'die("Oh, no, you don't!")') would be a
> good idea.
FWIW, fmt_ident() records the current time (before the kh/commit series,
and after the fix I sent on top of kh/commit series), which may be a
reasonable alternative.
next prev parent reply other threads:[~2007-12-02 22:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 16:06 Corrupted (?) commit 6e6db85e confusing gitk Steffen Prohaska
2007-12-02 16:12 ` Wincent Colaiuta
2007-12-02 16:36 ` [PATCH] gitk: Add workaround to handle corrupted author date Steffen Prohaska
2007-12-02 18:53 ` Corrupted (?) commit 6e6db85e confusing gitk Junio C Hamano
2007-12-02 19:39 ` Brian Downing
2007-12-02 20:34 ` Linus Torvalds
2007-12-02 20:48 ` Junio C Hamano
2007-12-02 21:25 ` Linus Torvalds
2007-12-02 21:47 ` Junio C Hamano
2007-12-02 22:43 ` Linus Torvalds
2007-12-02 21:43 ` Fix --signoff in builtin-commit differently Junio C Hamano
2007-12-02 22:31 ` Johannes Schindelin
2007-12-02 22:59 ` Corrupted (?) commit 6e6db85e confusing gitk Michael Gebetsroither
2007-12-02 23:05 ` Junio C Hamano
2007-12-02 21:34 ` Johannes Schindelin
2007-12-02 21:49 ` Linus Torvalds
2007-12-02 22:36 ` Junio C Hamano [this message]
2007-12-02 22:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbq98u3l1.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=bdowning@lavos.net \
--cc=git@vger.kernel.org \
--cc=prohaska@zib.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).