From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <gitster@pobox.com>
Subject: Re: [Resend Trivial PATCH] For the sake of correctness, fix file descriptor leak.
Date: Sun, 25 Nov 2007 14:29:07 -0800
Message-ID: <7vbq9ij6x8.fsf@gitster.siamese.dyndns.org>
References: <b8bf37780711211659v4fbd5936t29d0a0a2ff84f4b@mail.gmail.com>
	<b8bf37780711251337q41e02304q8fd2654b1e83201@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Git Mailing List" <git@vger.kernel.org>
To: =?utf-8?Q?Andr=C3=A9_Goddard_Rosa?= <andre.goddard@gmail.com>
X-From: git-owner@vger.kernel.org Sun Nov 25 23:29:42 2007
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1IwPyu-0007jh-AN
	for gcvg-git-2@gmane.org; Sun, 25 Nov 2007 23:29:40 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756432AbXKYW3P (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Sun, 25 Nov 2007 17:29:15 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756377AbXKYW3P
	(ORCPT <rfc822;git-outgoing>); Sun, 25 Nov 2007 17:29:15 -0500
Received: from sceptre.pobox.com ([207.106.133.20]:55163 "EHLO
	sceptre.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754363AbXKYW3O (ORCPT <rfc822;git@vger.kernel.org>);
	Sun, 25 Nov 2007 17:29:14 -0500
Received: from sceptre (localhost.localdomain [127.0.0.1])
	by sceptre.pobox.com (Postfix) with ESMTP id D371B2F9;
	Sun, 25 Nov 2007 17:29:35 -0500 (EST)
Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77])
	(using TLSv1 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	by sceptre.sasl.smtp.pobox.com (Postfix) with ESMTP id 7FA9099BA0;
	Sun, 25 Nov 2007 17:29:33 -0500 (EST)
In-Reply-To: <b8bf37780711251337q41e02304q8fd2654b1e83201@mail.gmail.com>
	(=?utf-8?Q?Andr=C3=A9?= Goddard Rosa's message of "Sun, 25 Nov 2007
 19:37:05 -0200")
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
Sender: git-owner@vger.kernel.org
Precedence: bulk
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/66020>

The codepath you are touching will exit immediately after an error
return; I do not feel much urgency to it, although I do not think the
patch would _hurt_.

Please follow the established convention for patch submission (see
patches on the list from other people as examples).