From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] Make GIT_INDEX_FILE apply to git-commit Date: Sat, 10 Nov 2007 10:45:28 -0800 Message-ID: <7vbqa2lz1z.fsf@gitster.siamese.dyndns.org> References: <87abpml8rx.dlv@vanicat.homelinux.org> <7vode2mljf.fsf@gitster.siamese.dyndns.org> <6b8a91420711101038t3b2ca647v422f81d9365dd05d@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org To: "Remi Vanicat" X-From: git-owner@vger.kernel.org Sat Nov 10 19:46:07 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IqvL5-0005XF-Hm for gcvg-git-2@gmane.org; Sat, 10 Nov 2007 19:45:51 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752776AbXKJSpd (ORCPT ); Sat, 10 Nov 2007 13:45:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752745AbXKJSpd (ORCPT ); Sat, 10 Nov 2007 13:45:33 -0500 Received: from sceptre.pobox.com ([207.106.133.20]:48405 "EHLO sceptre.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742AbXKJSpc (ORCPT ); Sat, 10 Nov 2007 13:45:32 -0500 Received: from sceptre (localhost.localdomain [127.0.0.1]) by sceptre.pobox.com (Postfix) with ESMTP id 27BBC2F2; Sat, 10 Nov 2007 13:45:54 -0500 (EST) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by sceptre.sasl.smtp.pobox.com (Postfix) with ESMTP id BCC7D93F4C; Sat, 10 Nov 2007 13:45:51 -0500 (EST) In-Reply-To: <6b8a91420711101038t3b2ca647v422f81d9365dd05d@mail.gmail.com> (Remi Vanicat's message of "Sat, 10 Nov 2007 19:38:34 +0100") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: "Remi Vanicat" writes: > 2007/11/10, Junio C Hamano : >> Sounds sensible. Tests? >> > > all test pass Sorry for being too terse. I did not mean existing tests. Additional tests to make sure your fix will not be broken by other people who touch the codepath later are requested.