git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Blake Ramsdell <blaker@gmail.com>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] Removed OLD_ICONV in favor of checking _LIBICONV_VERSION directly
Date: Fri, 02 Nov 2007 17:07:22 -0700	[thread overview]
Message-ID: <7vbqacyyx1.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1194048010-65955-1-git-send-email-blaker@gmail.com> (Blake Ramsdell's message of "Fri, 2 Nov 2007 17:00:10 -0700")

Blake Ramsdell <blaker@gmail.com> writes:

> diff --git a/utf8.c b/utf8.c
> index 4efef6f..a7feb4f 100644
> --- a/utf8.c
> +++ b/utf8.c
> @@ -300,7 +300,7 @@ int is_encoding_utf8(const char *name)
>   * with iconv.  If the conversion fails, returns NULL.
>   */
>  #ifndef NO_ICONV
> -#ifdef OLD_ICONV
> +#if _LIBICONV_VERSION <= 0x0109
>  	typedef const char * iconv_ibp;
>  #else
>  	typedef char * iconv_ibp;

Does everybody's iconv use the same _LIBICONV_VERSION scheme?

Compiling this:

        #include <iconv.h>
        int i = _LIBICONV_VERSION;

on a Linux box with GNU C library gives:

	i.c:3: error: '_LIBICONV_VERSION' undeclared here (not in a function)

here.

  reply	other threads:[~2007-11-03  0:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-02  2:38 [PATCH] Mac OS X 10.5 does not require the OLD_ICONV flag set Blake Ramsdell
2007-11-02  2:38 ` [PATCH] Fixed a gcc 4.0.1 complaint about an uninitialized variable Blake Ramsdell
2007-11-02  5:37   ` Junio C Hamano
2007-11-02  9:03 ` [PATCH] Mac OS X 10.5 does not require the OLD_ICONV flag set Junio C Hamano
2007-11-02  9:20   ` Blake Ramsdell
2007-11-02  9:30   ` Mike Hommey
2007-11-02  9:39     ` Benoit SIGOURE
2007-11-02  9:45       ` Mike Hommey
2007-11-02 10:19   ` David Symonds
2007-11-02 10:33     ` Junio C Hamano
2007-11-02 11:23       ` David Symonds
2007-11-02 20:03         ` Blake Ramsdell
2007-11-03  0:00           ` [PATCH] Removed OLD_ICONV in favor of checking _LIBICONV_VERSION directly Blake Ramsdell
2007-11-03  0:07             ` Junio C Hamano [this message]
2007-11-03  0:21               ` Blake Ramsdell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbqacyyx1.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=blaker@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).