Re: [PATCH] git-daemon: more powerful base-path/user-path settings, using formats.

[Junio C Hamano <junkio@cox.net>]

Pierre Habouzit <madcoder@debian.org> writes:

> Allow a form of virtualhosting, when %h format is used.
>
> Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> ---
>
>     This is intended to be a more flexible solution, that also gives virtual
>     hosting as a bonus. I still see no way to deal with older clients when
>     virtual hosting is used by the admin though, having a "default" hostname
>     won't solve anything at all anyway.

I mildly disagree about the last sentence.  Enabling virtual
hosting does not have to mean all virtual hosts are treated
equal.  It is conceivable that a site hosts the primary,
"collection of public repositories everybody would want to go
to" set, with supplemental ones for specific audiences that are
done via virtual hosting.  General public who would want to
access the primary one can come with older clients that way, and
only the narrower audiences have to be told to upgrade.

The client-side host= support was done post 1.4.0-rc1 timeframe
so we have to be nicer to 1.3 based people, at least give them a
way to slurp newer version with their client ;-).

Haven't looked at the rest of the patch yet.  Will comment
later.