git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Luben Tuikov <ltuikov@yahoo.com>
Cc: git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH] gitweb: bugfix: list regression
Date: Tue, 22 Aug 2006 02:19:29 -0700	[thread overview]
Message-ID: <7vbqqdnn4u.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060822085540.1104.qmail@web31812.mail.mud.yahoo.com> (Luben Tuikov's message of "Tue, 22 Aug 2006 01:55:40 -0700 (PDT)")

Luben Tuikov <ltuikov@yahoo.com> writes:

> Fix regression introduced by
> commit 17d07443188909ef5f8b8c24043cb6d9fef51bca.
>
> 1. Commit 17d07443188909ef5f8b8c24043cb6d9fef51bca defines
> "a.list" twice in gitweb.css, once with bold and once with
> normal font-weight.

The normal one is limited to a.list that is inside table.tags
isn't it?  I had an impression that this was done on purpose.

> 2. "a.list" being "bold", makes a myriad of things shown by
> gitweb in bold font-weight, which is a regression from
> pre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.

The only difference I see offhand is that Jakub's version shows
the tag text in normal weight in summary pane (tags section),
while yours show it in bold.  Also clickable object names in
many views are shown in bold in Jakub's version while yours do
not distinguish them from unclickable ones.

I tend to agree that bold looks too loud in tree view, but
showing tree and parent diffently from commit itself in commit
view may be a good thing.  I am not sure bold is a good choice,
though.  Usually people underline clickable links not type in
bold.

I do not case either way myself that much.  Could you battle
this out with the guilty party?

  reply	other threads:[~2006-08-22  9:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-22  8:55 [PATCH] gitweb: bugfix: list regression Luben Tuikov
2006-08-22  9:19 ` Junio C Hamano [this message]
2006-08-22  9:30 ` Jakub Narebski
2006-08-22 10:02 ` [PATCH] gitweb: bugfix: a.list formatting regression Jakub Narebski
2006-08-22 22:34   ` Junio C Hamano
2006-08-22 22:46     ` Jakub Narebski
2006-08-22 23:14       ` Junio C Hamano
2006-08-23  4:43   ` Luben Tuikov
2006-08-23  4:45   ` Luben Tuikov
2006-08-23  5:23     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbqqdnn4u.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=ltuikov@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).