git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Robert Shearman <rob@codeweavers.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] format-patch: Generate a newline between the subject header and the message body.
Date: Thu, 13 Jul 2006 14:31:01 -0700	[thread overview]
Message-ID: <7vbqrtur8q.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <44B6369D.6070602@codeweavers.com> (Robert Shearman's message of "Thu, 13 Jul 2006 13:03:41 +0100")

Robert Shearman <rob@codeweavers.com> writes:

> This patch inserts a newline in two places - once in the loop to
> separate the subject part of the commit message from the body part of
> the commit message and another after the loop to counteract the eating
> of whitespace at the end of the message.

Thanks.

 * Please sign your patch.

 * This breaks a handful t4013 tests, but all in a good way (in
   other words, the expected output files were wrong).

I'll fix up the t/t4013/diff.* files myself.

  parent reply	other threads:[~2006-07-13 21:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-13 12:03 [PATCH] format-patch: Generate a newline between the subject header and the message body Robert Shearman
2006-07-13 19:38 ` Jakub Narebski
2006-07-13 20:03   ` Robert Shearman
2006-07-13 21:31 ` Junio C Hamano [this message]
2006-07-13 21:48   ` Junio C Hamano
2006-07-13 21:55     ` Robert Shearman
  -- strict thread matches above, loose matches on Subject: below --
2006-07-13 22:17 Robert Shearman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbqrtur8q.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=rob@codeweavers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).