From: Junio C Hamano <junkio@cox.net>
To: Petr Baudis <pasky@suse.cz>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Make git-send-pack exit with error when some refs couldn't be pushed out
Date: Tue, 13 Dec 2005 17:50:02 -0800 [thread overview]
Message-ID: <7vbqzk5tx1.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20051214004540.15040.93518.stgit@machine.or.cz> (Petr Baudis's message of "Wed, 14 Dec 2005 01:45:40 +0100")
Petr Baudis <pasky@suse.cz> writes:
> In case some refs couldn't be pushed out due to an error (mostly the
> not-a-proper-subset error), make git-send-pack exit with non-zero status
> after the push is over (that is, it still tries to push out the rest
> of the refs).
I agree this change to send-pack is a good fix (I haven't looked
at the code, but the above description describes a good fix).
However, I am not quite sure if the recent change to Cogito to
update the mirror of remote branch is a good one. Since I am
not a Cogito user, I did not question it when I saw the change,
but I wondered what you are using the cached "remote ref is
supposed to be pointing at this commit" knowledge for. If it is
only "pretending to have fetched the remote branch immediately
after we pushed into it before anybody else touched the same
remote branch", then it probably is benign. But this bit
puzzles and worries me:
> ... otherwise
> it gets out of sync, which can lead even to loss of commits on the local
> side (this happenned to Jonas Fonseca - thanks for the report, BTW).
I do not remember seeing that report so I do not know how that
lossage happens with unreleased Cogito, but I suspect there is
something very fishy going on here. I presume it happens when
the next fetch/pull from the remote is run, but if the locally
cached information can affect the next fetch/pull in such a way,
wouldn't updates by other people to the shared remote repository
branch also cause things to go out-of-sync and cause the same
breakage?
next prev parent reply other threads:[~2005-12-14 1:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 0:45 [PATCH] Make git-send-pack exit with error when some refs couldn't be pushed out Petr Baudis
2005-12-14 1:50 ` Junio C Hamano [this message]
2005-12-14 2:30 ` Petr Baudis
2005-12-14 16:15 ` [PATCH] Make git-send-pack exit with error when some refs cou ldn't " Jon Loeliger
2005-12-14 19:01 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbqzk5tx1.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).