From: Junio C Hamano <junkio@cox.net>
To: git@vger.kernel.org
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: [PATCH] config.c: remove unnecessary header in minimum configuration file.
Date: Fri, 25 Nov 2005 14:22:14 -0800 [thread overview]
Message-ID: <7vbr08mkq1.fsf@assigned-by-dhcp.cox.net> (raw)
It is just silly to start the file called "config" a comment
that says "This is the config file."
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
config.c | 8 --------
t/t1300-repo-config.sh | 20 --------------------
2 files changed, 0 insertions(+), 28 deletions(-)
applies-to: f316bfd81eaa2064c1d9e01a336eaed8d7a5bd4f
55c2454c6f18323b5ff04504593603848084aa4d
diff --git a/config.c b/config.c
index 5cc8535..52659f9 100644
--- a/config.c
+++ b/config.c
@@ -445,12 +445,6 @@ int git_config_set_multivar(const char*
* If .git/config does not exist yet, write a minimal version.
*/
if (stat(config_filename, &st)) {
- static const char contents[] =
- "#\n"
- "# This is the config file\n"
- "#\n"
- "\n";
-
free(store.key);
/* if nothing to unset, error out */
@@ -461,8 +455,6 @@ int git_config_set_multivar(const char*
}
store.key = (char*)key;
-
- write(fd, contents, sizeof(contents)-1);
store_write_section(fd, key);
store_write_pair(fd, key, value);
} else{
diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
index 5e994ff..207dd3d 100644
--- a/t/t1300-repo-config.sh
+++ b/t/t1300-repo-config.sh
@@ -12,10 +12,6 @@ test -f .git/config && rm .git/config
git-repo-config core.penguin "little blue"
cat > expect << EOF
-#
-# This is the config file
-#
-
[core]
penguin = little blue
EOF
@@ -25,10 +21,6 @@ test_expect_success 'initial' 'cmp .git/
git-repo-config Core.Movie BadPhysics
cat > expect << EOF
-#
-# This is the config file
-#
-
[core]
penguin = little blue
Movie = BadPhysics
@@ -39,10 +31,6 @@ test_expect_success 'mixed case' 'cmp .g
git-repo-config Cores.WhatEver Second
cat > expect << EOF
-#
-# This is the config file
-#
-
[core]
penguin = little blue
Movie = BadPhysics
@@ -55,10 +43,6 @@ test_expect_success 'similar section' 'c
git-repo-config CORE.UPPERCASE true
cat > expect << EOF
-#
-# This is the config file
-#
-
[core]
penguin = little blue
Movie = BadPhysics
@@ -76,10 +60,6 @@ test_expect_success 'replace with non-ma
'git-repo-config core.penguin "very blue" !kingpin'
cat > expect << EOF
-#
-# This is the config file
-#
-
[core]
penguin = very blue
Movie = BadPhysics
---
0.99.9.GIT
next reply other threads:[~2005-11-25 22:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-25 22:22 Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-11-25 22:22 [PATCH] config.c: remove unnecessary header in minimum configuration file Junio C Hamano
2005-12-05 0:27 ` Junio C Hamano
2005-12-05 11:32 ` Andreas Ericsson
2005-12-05 20:25 ` Johannes Schindelin
2005-12-05 20:56 ` Junio C Hamano
2005-12-05 21:05 ` Johannes Schindelin
2005-12-05 21:47 ` Junio C Hamano
2005-12-05 22:16 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbr08mkq1.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).