From: Junio C Hamano <junkio@cox.net>
To: "Sean" <seanlkml@sympatico.ca>
Cc: "Junio C Hamano" <junkio@cox.net>,
"Linus Torvalds" <torvalds@osdl.org>,
git@vger.kernel.org
Subject: Re: [PATCH] Introduce SHA1_FILE_DIRECTORIES
Date: Fri, 06 May 2005 23:31:34 -0700 [thread overview]
Message-ID: <7vbr7nbl89.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <2721.10.10.10.24.1115425962.squirrel@linux1> (seanlkml@sympatico.ca's message of "Fri, 6 May 2005 20:32:42 -0400 (EDT)")
>>>>> "S" == Sean <seanlkml@sympatico.ca> writes:
S> Perhaps I'm just missing something in your code,...
Yes you are. You have spotted a very inconvenient inconsistency
in the interface to the code.
Only on the very first time when it tries to constructs the
alternate directory list, and if there is no alternate list, it
just returns the name without stat(), which forces the callers
to do stat() themselves all the time. I think I should make it
always stat, since the reading side needs do it anyway.
Thankfully I think Linus had rejected this part in the series.
I'll fix it up.
next prev parent reply other threads:[~2005-05-07 6:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-06 23:35 [PATCH] Introduce SHA1_FILE_DIRECTORIES Junio C Hamano
2005-05-07 0:20 ` Sean
2005-05-07 0:24 ` Junio C Hamano
2005-05-07 0:32 ` Sean
2005-05-07 6:31 ` Junio C Hamano [this message]
2005-05-07 19:51 ` Junio C Hamano
2005-05-09 13:33 ` H. Peter Anvin
2005-05-09 16:38 ` Junio C Hamano
2005-05-09 16:41 ` Sean
2005-05-09 18:03 ` H. Peter Anvin
2005-05-09 18:50 ` Junio C Hamano
2005-05-09 20:05 ` [RFC] Renaming environment variables Junio C Hamano
2005-05-09 20:15 ` Thomas Glanzmann
2005-05-10 0:32 ` Petr Baudis
2005-05-09 21:04 ` Sean
2005-05-09 23:08 ` Daniel Barkalow
2005-05-10 0:09 ` Junio C Hamano
2005-05-10 0:13 ` Petr Baudis
2005-05-10 0:22 ` Junio C Hamano
2005-05-10 0:27 ` Petr Baudis
2005-05-10 0:38 ` Daniel Barkalow
2005-05-10 0:44 ` Petr Baudis
2005-05-10 0:53 ` Daniel Barkalow
2005-05-10 5:45 ` Junio C Hamano
2005-05-10 6:25 ` Introducing GIT_DIR environment variable Junio C Hamano
2005-05-10 23:39 ` Alex Riesen
2005-05-10 2:16 ` [RFC] Renaming environment variables Junio C Hamano
2005-05-10 3:23 ` Daniel Barkalow
2005-05-10 0:25 ` Petr Baudis
2005-05-10 1:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbr7nbl89.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=seanlkml@sympatico.ca \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox