From: Junio C Hamano <gitster@pobox.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] sha1_name: fix error message for @{<N>}, @{<date>}
Date: Fri, 24 May 2013 09:52:43 -0700 [thread overview]
Message-ID: <7vd2sgb9r8.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1369381324-10206-3-git-send-email-artagnon@gmail.com> (Ramkumar Ramachandra's message of "Fri, 24 May 2013 13:12:04 +0530")
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> Currently, when we try to resolve @{<N>} or @{<date>} when the reflog
> doesn't go back far enough, we get errors like:
>
> # on branch master
> $ git show @{10000}
> fatal: Log for '' only has 7 entries.
>
> $ git show @{10000.days.ago}
> warning: Log for '' only goes back to Tue, 21 May 2013 14:14:45 +0530.
> ...
>
> # detached HEAD case
> $ git show @{10000}
> fatal: Log for '' only has 2005 entries.
>
> $ git show master@{10000}
> fatal: Log for 'master' only has 7 entries.
>
> The empty string '' is ugly, inconsistent, and fails to convey
> information about whose logs we are inspecting. Change this so that we
What is this meant to update? I recall rewriting this part on
purpose.
Even though it appears unusual and invites confusion, it is very
consistent to say '' when the user asks for @... as we say 'master'
when the user asks for master@...; "inconsistent" is a very bad
label for it.
next prev parent reply other threads:[~2013-05-24 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 7:42 [PATCH v3 0/2] Replacement for rr/die-on-missing-upstream Ramkumar Ramachandra
2013-05-24 7:42 ` [PATCH 1/2] sha1_name: fix error message for @{u} Ramkumar Ramachandra
2013-05-24 7:42 ` [PATCH 2/2] sha1_name: fix error message for @{<N>}, @{<date>} Ramkumar Ramachandra
2013-05-24 16:52 ` Junio C Hamano [this message]
2013-05-24 17:24 ` Ramkumar Ramachandra
2013-05-24 17:46 ` Junio C Hamano
2013-05-24 17:50 ` Ramkumar Ramachandra
-- strict thread matches above, loose matches on Subject: below --
2013-05-22 10:39 [PATCH v2 0/2] Fix invalid revision error messages Ramkumar Ramachandra
2013-05-22 10:39 ` [PATCH 2/2] sha1_name: fix error message for @{<N>}, @{<date>} Ramkumar Ramachandra
2013-05-22 20:39 ` Eric Sunshine
2013-05-21 10:41 [PATCH 0/2] Fix invalid revision error messages for 1.8.3 Ramkumar Ramachandra
2013-05-21 10:41 ` [PATCH 2/2] sha1_name: fix error message for @{<N>}, @{<date>} Ramkumar Ramachandra
2013-05-21 16:52 ` Junio C Hamano
2013-05-21 17:38 ` Kevin Bracey
2013-05-21 18:09 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd2sgb9r8.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).