git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 0/2] remote-bzr: couple of fixes
Date: Sun, 05 May 2013 11:33:41 -0700	[thread overview]
Message-ID: <7vd2t5uvi2.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1367627467-15132-1-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Fri, 3 May 2013 19:31:05 -0500")

Felipe Contreras <felipe.contreras@gmail.com> writes:

> The previous version had an indentation bug (did I mention I hate python?).
>
> A few fixes to be applied on top of the massive changes already queued. Nothing
> major.

[2/2] may not matter much in the context of my tree (people would
use post 1.8.2 fast-export if they are using remote-bzr from 1.8.3
from my tree ;-), but [1/2] sounds like it is a good thing to have
in 1.8.3 (not "on top of that 'massive' series").

Assuming the "otherwise some version of bzr might barf" problem is
that repo.generate_revision_history() in those versions may not
apply str() to its first parameter and the caller is expected to
pass a string there, or something?

Thanks.

>
> Felipe Contreras (2):
>   remote-bzr: convert all unicode keys to str
>   remote-bzr: avoid bad refs
>
>  contrib/remote-helpers/git-remote-bzr | 42 +++++++++++++++++++++--------------
>  1 file changed, 25 insertions(+), 17 deletions(-)

  parent reply	other threads:[~2013-05-05 18:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-04  0:31 [PATCH v2 0/2] remote-bzr: couple of fixes Felipe Contreras
2013-05-04  0:31 ` [PATCH v2 1/2] remote-bzr: convert all unicode keys to str Felipe Contreras
2013-05-04  0:31 ` [PATCH v2 2/2] remote-bzr: avoid bad refs Felipe Contreras
2013-05-04  8:39   ` Stefano Lattarini
2013-05-05 18:33 ` Junio C Hamano [this message]
2013-05-05 18:42   ` [PATCH v2 0/2] remote-bzr: couple of fixes Felipe Contreras
2013-05-05 19:03     ` Junio C Hamano
2013-05-05 20:24       ` Felipe Contreras
2013-05-05 20:58         ` Junio C Hamano
2013-05-05 21:54           ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd2t5uvi2.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).