From: Junio C Hamano <gitster@pobox.com>
To: Antoine Pelisse <apelisse@gmail.com>
Cc: git <git@vger.kernel.org>, Rich Midwinter <rich.midwinter@gmail.com>
Subject: Re: [PATCH 5/5] log: Add --use-mailmap option
Date: Wed, 12 Dec 2012 09:58:38 -0800 [thread overview]
Message-ID: <7vd2yf5f01.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CALWbr2xmRVS9m623yrxY88Ftaen_B8Tb2vd+VxhYV1ceAmbDSg@mail.gmail.com> (Antoine Pelisse's message of "Wed, 12 Dec 2012 12:58:59 +0100")
Antoine Pelisse <apelisse@gmail.com> writes:
> On Tue, Dec 11, 2012 at 11:21 PM, Antoine Pelisse <apelisse@gmail.com> wrote:
>> Add the --use-mailmap option to log commands. It allows
>> to display names from mailmap file when displaying logs,
>> whatever the format used.
>
> The question is which log commands actually ?
> Shouldn't we put the option in revision.c::handle_revision_opt instead ?
I was trying to avoid that to make it harder to trigger the
"feature" by mistake. The rewriting with mailmap is for human
consumption and when we replay the history (e.g. format-patch used
as input for am or rebase), we should never be applying it.
next prev parent reply other threads:[~2012-12-12 17:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 22:21 [PATCH 0/5] Allow git log to use mailmap file Antoine Pelisse
2012-12-11 22:21 ` [PATCH 1/5] Use split_ident_line to parse author and committer Antoine Pelisse
2012-12-11 22:21 ` [PATCH 2/5] mailmap: Remove buffer length limit in map_user Antoine Pelisse
2012-12-11 22:21 ` [PATCH 3/5] mailmap: Add mailmap structure to rev_info and pp Antoine Pelisse
2012-12-11 22:21 ` [PATCH 4/5] pretty: Use mailmap to display username and email Antoine Pelisse
2012-12-11 22:46 ` Junio C Hamano
2012-12-12 13:27 ` Antoine Pelisse
2012-12-11 22:21 ` [PATCH 5/5] log: Add --use-mailmap option Antoine Pelisse
2012-12-12 11:58 ` Antoine Pelisse
2012-12-12 17:58 ` Junio C Hamano [this message]
2012-12-11 22:33 ` [PATCH 0/5] Allow git log to use mailmap file Junio C Hamano
2012-12-11 22:41 ` Rich Midwinter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd2yf5f01.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=apelisse@gmail.com \
--cc=git@vger.kernel.org \
--cc=rich.midwinter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).