* Commit message problem of reverting multiple commits
@ 2012-11-13 15:15 乙酸鋰
2012-11-13 16:34 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: 乙酸鋰 @ 2012-11-13 15:15 UTC (permalink / raw)
To: git
Hi,
I ran git 1.8.0 command line
git revert --no-commit rev1 rev2
I see a prepared commit message like
Revert "<description from one commit>"
This reverts commit <SHA1 of one commit>.
The actual revert content is correct - it is all the relevant commits
that were selected. I expect the message to reflect this:
Revert "<description from commit1>", "<description from commit2>"
This reverts commits <SHA1 of commit1>, <SHA1 of commit2>.
Regards,
ch3cooli
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Commit message problem of reverting multiple commits
2012-11-13 15:15 Commit message problem of reverting multiple commits 乙酸鋰
@ 2012-11-13 16:34 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2012-11-13 16:34 UTC (permalink / raw)
To: 乙酸鋰; +Cc: git
乙酸鋰 <ch3cooli@gmail.com> writes:
> I ran git 1.8.0 command line
>
> git revert --no-commit rev1 rev2
>
> I see a prepared commit message like
>
> Revert "<description from one commit>"
> This reverts commit <SHA1 of one commit>.
>
>
> The actual revert content is correct - it is all the relevant commits
> that were selected. I expect the message to reflect this:
>
> Revert "<description from commit1>", "<description from commit2>"
> This reverts commits <SHA1 of commit1>, <SHA1 of commit2>.
Hrmph. I actually think the revert-content is not correct.
I think the command should not take more than one commit on the
command line when --no-commit is in use in the first place (the same
thing can be said for cherry-pick). After all, "git revert rev1
rev2" is to revert rev1 and then rev2 independently, so unless that
option is spelled "--squash", the resulting history should have two
commits that reverts rev1 and rev2 independently.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-13 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-13 15:15 Commit message problem of reverting multiple commits 乙酸鋰
2012-11-13 16:34 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).