From: Junio C Hamano <gitster@pobox.com>
To: David Aguilar <davvid@gmail.com>
Cc: Tim Henigan <tim.henigan@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] difftool: Handle compare() returning -1
Date: Thu, 26 Jul 2012 12:07:51 -0700 [thread overview]
Message-ID: <7vd33i733s.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1343282878-86431-2-git-send-email-davvid@gmail.com> (David Aguilar's message of "Wed, 25 Jul 2012 23:07:58 -0700")
David Aguilar <davvid@gmail.com> writes:
> +sub exit_cleanup
> +{
> + my ($tmpdir, $status) = @_;
> + rmtree($tmpdir);
> + if ($status and $!) {
> + my ($package, $file, $line) = caller();
> + warn "$file line $line: $!\n";
Are you sure rmtree() would not clobber $! before the code checks it
here?
next prev parent reply other threads:[~2012-07-26 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 6:07 [PATCH 1/2] difftool: Wrap long lines for readability David Aguilar
2012-07-26 6:07 ` [PATCH 2/2] difftool: Handle compare() returning -1 David Aguilar
2012-07-26 19:07 ` Junio C Hamano [this message]
2012-07-26 19:25 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd33i733s.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=tim.henigan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).