git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Chris Kees <cekees@gmail.com>, git@vger.kernel.org
Subject: Re: --progress for git submodule update?
Date: Wed, 14 Mar 2012 14:45:05 -0700	[thread overview]
Message-ID: <7vd38eoo0u.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4F60F4A6.1070507@web.de> (Jens Lehmann's message of "Wed, 14 Mar 2012 20:42:30 +0100")

Jens Lehmann <Jens.Lehmann@web.de> writes:

> Am 13.03.2012 03:17, schrieb Chris Kees:
>> It's 'git submodule update --recursive' that is taking so long
>> silently.  The problem is mainly on the first time. There are about 10
>> submodules that together have taken more than 30 minutes. It's not
>> really just the amount of data, I think there are also network traffic
>> issues that slow things down on some systems.
>
> I suppose with "first time" you mean right after "git submodule init",
> when the submodules have to be cloned initially? Thinking about that
> again, you mentioned a buildbot doing all that. When the submodules
> are updated from a script, no progress output is shown at all and only
> the line "Cloning into 'xxx'..." will appear for each submodule, which
> explains why you don't see output for quite some time.
>
> So I suspect increasing the timeout on your buildbot is the way to go,
> as progress output is intended for humans.

Considering that more often than not, people who run stuff from cronjob
request us to be quiet when nothing wrong happens, I think that is a
sane thing to suggest.

I do not mind "submodule $subcmd --progress" to pass "--progress" down to
whatever underlying git commands it uses, or squelch "-q" that it uses
when running them by default, though.

We may even want to make "git submodule init -q" to squelch the "Cloning
into..." message, but that is a separate topic.

  reply	other threads:[~2012-03-14 21:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-10  7:17 --progress for git submodule update? Chris Kees
2012-03-11 20:50 ` Jens Lehmann
2012-03-13  2:17   ` Chris Kees
2012-03-14 19:42     ` Jens Lehmann
2012-03-14 21:45       ` Junio C Hamano [this message]
2012-03-15  3:43         ` Chris Kees
2012-03-15 22:34           ` Jens Lehmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd38eoo0u.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Jens.Lehmann@web.de \
    --cc=cekees@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).