From: Junio C Hamano <gitster@pobox.com>
To: "Frans Klaver" <fransklaver@gmail.com>
Cc: "Jonathan Nieder" <jrnieder@gmail.com>,
git@vger.kernel.org, "Johannes Sixt" <j6t@kdbg.org>
Subject: Re: [PATCH 1/5] t0061: Fix incorrect indentation
Date: Tue, 24 Jan 2012 23:00:57 -0800 [thread overview]
Message-ID: <7vd3a8466u.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <op.v8mmwftk0aolir@keputer> (Frans Klaver's message of "Wed, 25 Jan 2012 07:27:41 +0100")
"Frans Klaver" <fransklaver@gmail.com> writes:
> On Tue, 24 Jan 2012 23:40:00 +0100, Jonathan Nieder
> <jrnieder@gmail.com> wrote:
>
>> Frans Klaver wrote:
>>
>>> +++ b/t/t0061-run-command.sh
>>> @@ -8,8 +8,8 @@ test_description='Test run command'
>>> . ./test-lib.sh
>>>
>>> cat >hello-script <<-EOF
>>> - #!$SHELL_PATH
>>> - cat hello-script
>>> +#!$SHELL_PATH
>>> +cat hello-script
>>> EOF
>>
>> Looks like a no-op --- the script already started with #! and no
>> leading tab for me. Does it behave differently on your machine?
>
> Hurr? I'm fairly sure the script ended up being indented for me. I'll
> recheck.
It could be that your shell is broken and does not understand the
distinction between the "<<-EOF" vs "<<EOF". What system are you on? If
the problem is real and widespread, we might want to mention it in INSTALL
or Makefile, just like we label Solaris /bin/sh as unusable and advise
people to use /usr/xpg[46]/bin variant.
next prev parent reply other threads:[~2012-01-25 7:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 22:32 [PATCH 0/6 v3] Add execvp failure diagnostics Frans Klaver
2012-01-24 22:32 ` [PATCH 1/5] t0061: Fix incorrect indentation Frans Klaver
2012-01-24 22:39 ` Junio C Hamano
2012-01-24 22:40 ` Jonathan Nieder
2012-01-25 6:27 ` Frans Klaver
2012-01-25 7:00 ` Junio C Hamano [this message]
2012-01-25 7:08 ` Frans Klaver
2012-01-25 8:08 ` Frans Klaver
2012-01-24 22:32 ` [PATCH 2/5] t0061: Add tests Frans Klaver
2012-01-24 22:56 ` Jonathan Nieder
2012-01-25 6:47 ` Frans Klaver
2012-01-24 22:32 ` [PATCH 3/5] run-command: Elaborate execvp error checking Frans Klaver
2012-01-24 23:22 ` Jonathan Nieder
2012-01-25 7:09 ` Frans Klaver
2012-01-25 19:22 ` Jonathan Nieder
2012-01-25 22:48 ` Frans Klaver
2012-01-25 19:03 ` Johannes Sixt
2012-01-25 22:59 ` Frans Klaver
2012-01-24 22:32 ` [PATCH 4/5] run-command: Warn if PATH entry cannot be searched Frans Klaver
2012-01-24 22:32 ` [PATCH 5/5] run-command: Error out if interpreter not found Frans Klaver
2012-01-24 23:24 ` Jonathan Nieder
2012-01-25 7:12 ` Frans Klaver
2012-01-25 18:55 ` Johannes Sixt
2012-01-25 23:09 ` Frans Klaver
2012-01-26 19:32 ` Junio C Hamano
2012-01-27 8:29 ` Frans Klaver
2012-01-27 8:48 ` Jonathan Nieder
2012-01-27 9:11 ` Frans Klaver
2012-01-27 9:41 ` Jonathan Nieder
2012-01-27 11:46 ` Frans Klaver
2012-02-04 21:31 ` Frans Klaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd3a8466u.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=fransklaver@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).