From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] receive-pack, fetch-pack: reject bogus pack that records objects twice
Date: Fri, 18 Nov 2011 10:41:35 -0800 [thread overview]
Message-ID: <7vd3cpl1cw.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20111118103355.GA4854@sigill.intra.peff.net> (Jeff King's message of "Fri, 18 Nov 2011 05:33:55 -0500")
Jeff King <peff@peff.net> writes:
> If we are fixing a thin pack (which should be the case most of the
> time), we are rewriting the packfile anyway. Shouldn't we just omit
> the duplicate?
Excising unwanted objects from the middle of an existing packfile would
mean you would need an equivalent of memmove() in the file, which amounts
to really rewriting the packfile, but the thing is, we are _not_ rewriting
in that sense in "index-pack --fix-thin"; it only appends and adjust the
fixed-size header.
next prev parent reply other threads:[~2011-11-18 18:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 6:04 [PATCH] receive-pack, fetch-pack: reject bogus pack that records objects twice Junio C Hamano
2011-11-17 20:51 ` Shawn Pearce
2011-11-18 10:33 ` Jeff King
2011-11-18 18:41 ` Junio C Hamano [this message]
2011-11-18 18:44 ` Jeff King
2011-11-18 19:22 ` Junio C Hamano
2011-11-18 21:08 ` Jeff King
2011-11-18 23:50 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd3cpl1cw.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).