git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: git@vger.kernel.org, msysgit@googlegroups.com
Subject: Re: [PATCH] blame.c: Properly initialize strbuf after calling, textconv_object()
Date: Fri, 28 Oct 2011 10:20:11 -0700	[thread overview]
Message-ID: <7vd3dht4ms.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAHGBnuNpwZCpQxZQNRZ-pYpLMHMi1O4d0hsR9MKM3=7Hw5A=zw@mail.gmail.com> (Sebastian Schuberth's message of "Fri, 28 Oct 2011 19:17:31 +0200")

Sebastian Schuberth <sschuberth@gmail.com> writes:

> On Fri, Oct 28, 2011 at 18:44, Junio C Hamano <gitster@pobox.com> wrote:
>
>>>> Thanks; do you have no addition to the test suite to demonstrate the
>>>> breakage?
>>>
>>> Not yet. I'll try to come up with something.
>>
>> Let's do this.
>
> Thanks, but that does not seem to work for me. The test breaks both
> without and with my patch. I'll look into it.

Thanks. I suspect the difference is because you are on a crlf-native
platform while I am not...

  reply	other threads:[~2011-10-28 17:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-28 15:28 [PATCH] blame.c: Properly initialize strbuf after calling, textconv_object() Sebastian Schuberth
2011-10-28 16:00 ` Junio C Hamano
2011-10-28 16:32   ` Sebastian Schuberth
2011-10-28 16:44     ` Junio C Hamano
2011-10-28 17:17       ` Sebastian Schuberth
2011-10-28 17:20         ` Junio C Hamano [this message]
2011-10-28 18:36           ` Sebastian Schuberth
2011-10-31 17:57           ` Sebastian Schuberth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd3dht4ms.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=msysgit@googlegroups.com \
    --cc=sschuberth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).