From: Junio C Hamano <gitster@pobox.com>
To: BJ Hargrave <bj@bjhargrave.com>
Cc: git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [ANNOUNCE] Git 1.7.6.4
Date: Fri, 23 Sep 2011 20:50:32 -0700 [thread overview]
Message-ID: <7vd3eqsinr.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4850EB43-5CC7-4D33-90A8-1EDEE16ECAB7@bjhargrave.com> (BJ Hargrave's message of "Fri, 23 Sep 2011 23:33:23 -0400")
BJ Hargrave <bj@bjhargrave.com> writes:
> The test
>
> invalid_ref "$(printf 'heads/foo\177')"
>
> was added to t1402-check-ref-format.sh. However sh on my RHEL 4 system
> does not handle the DEL (\177) character well in double quoted strings.
>
> sh-3.00$ echo $(printf 'hello\177') | hexdump -C
> 00000000 68 65 6c 6c 6f 7f 0a |hello..|
> 00000007
> sh-3.00$ echo "$(printf 'hello\177')" | hexdump -C
> 00000000 68 65 6c 6c 6f 0a |hello.|
> 00000006
>
> The double quotes cause the DEL (\177) character to be discarded.
>
> Can this test be rewritten to avoid this apparent bug in sh on RHEL 4?
For older distros, I would prefer a workaround patch first tested by
distro packaging people and then upstreamed.
Thanks.
next prev parent reply other threads:[~2011-09-24 3:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 23:37 [ANNOUNCE] Git 1.7.6.4 Junio C Hamano
2011-09-24 3:33 ` BJ Hargrave
2011-09-24 3:50 ` Junio C Hamano [this message]
2011-09-24 10:35 ` Robin H. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd3eqsinr.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=bj@bjhargrave.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).