From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: "Bert Wesarg" <bert.wesarg@googlemail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Thiago dos Santos Alvest" <hiago.salves@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] grep: add known breakage of coloring when using extended patterns
Date: Mon, 02 May 2011 10:37:52 -0700 [thread overview]
Message-ID: <7vd3k1ngun.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4DBEE672.5070707@lsrfire.ath.cx> ("René Scharfe"'s message of "Mon, 02 May 2011 19:14:26 +0200")
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
>> + test_commit initial input "foo bar baz
...
>> + git grep --color -e foo --or \( -e bar --and --not -e baz \) |
...
> The current code highlights the given search terms ("atoms").
Hmm, I was probably not paying attention to "coloring the parts that
matched" topic at all, but wouldn't it be easier and more efficient to
paint only "foo" without painting "bar baz"? We know the first term "foo"
matches, and the rest \(...\) that is --or'ed does not have to even be
evaluated, no?
next prev parent reply other threads:[~2011-05-02 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 11:35 [PATCH] grep: add known breakage of coloring when using extended patterns Bert Wesarg
2011-05-02 11:41 ` Johannes Sixt
2011-05-02 11:48 ` Bert Wesarg
2011-05-02 17:14 ` René Scharfe
2011-05-02 17:37 ` Junio C Hamano [this message]
2011-05-02 21:07 ` René Scharfe
2011-05-02 22:04 ` Junio C Hamano
2011-05-03 17:36 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd3k1ngun.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=hiago.salves@gmail.com \
--cc=pclouds@gmail.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).