git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: "Nguyen Thai Ngoc Duy" <pclouds@gmail.com>,
	git@vger.kernel.org, "Sebastian Pipping" <webmaster@hartwork.org>,
	"SZEDER Gábor" <szeder@ira.uka.de>, "Jeff King" <peff@peff.net>
Subject: Re: [PATCH 1.8.0] add: make "add -u" update full tree without pathspec
Date: Tue, 01 Mar 2011 10:40:18 -0800	[thread overview]
Message-ID: <7vd3maelbh.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <vpqipw2rixy.fsf@bauges.imag.fr> (Matthieu Moy's message of "Tue\, 01 Mar 2011 15\:53\:13 +0100")

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> I think promoting "git add -u ." more than a configuration option would
> reduce the pain.

Yeah, I tend to agree.

> As a user, if I get used to typing "git add -u ." instead of "git add -u", 
> I get the current behavior regardless of the version of Git, without a
> warning. Later, when all the machines I word on support the tree-wide
> "git add -u" (either 1.7.x + some configuration or 1.8.y), I'll use it
> as a new feature.

Once your users (you as a script writer) have an option to set the
configuration to participate in the tree-wide party early, you would need
to update your scripts immediately so that they don't break on them; so
the introduction of the configuration becomes a flag-day event.  Hmph...

> So, a warning like
>
>   warning: the behavior of "git add -u" without pathspec will change in
>   Git 1.8.0. To keep the current behavior, use this instead:
>   
>       git add -u .
>   
>   + explanations about the config options as already discussed here
>
> would be fine.

Yeah, I think you convinced me that an elaborate configuration wouldn't
help us at all.  We just keep warning in 1.7.x series when "add -u" didn't
see any pathspec, and flip the default at 1.8.0

Simpler and cleaner ;-)

  reply	other threads:[~2011-03-01 18:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07  2:27 [PATCH 1.8.0] add: make "add -u" update full tree without pathspec Nguyễn Thái Ngọc Duy
2011-02-07  5:58 ` Junio C Hamano
2011-02-07  6:14   ` Nguyen Thai Ngoc Duy
2011-02-07  6:26     ` Miles Bader
2011-02-09 10:58     ` Joshua Juran
2011-02-07 12:09   ` Matthieu Moy
2011-02-27 10:46 ` Junio C Hamano
2011-02-27 11:43   ` Matthieu Moy
2011-02-27 17:04     ` Nguyen Thai Ngoc Duy
2011-02-27 13:35   ` Sverre Rabbelier
2011-02-27 17:01     ` Nguyen Thai Ngoc Duy
2011-02-27 16:52   ` Nguyen Thai Ngoc Duy
2011-02-27 19:39     ` Junio C Hamano
2011-02-28  6:37       ` Nguyen Thai Ngoc Duy
2011-02-28  6:56         ` Junio C Hamano
2011-03-01 11:22           ` Nguyen Thai Ngoc Duy
2011-03-01 13:46             ` Junio C Hamano
2011-03-01 14:15               ` Nguyen Thai Ngoc Duy
2011-03-01 14:53           ` Matthieu Moy
2011-03-01 18:40             ` Junio C Hamano [this message]
2011-03-01 18:51               ` Matthieu Moy
2011-03-01 19:36                 ` Jakub Narebski
2011-03-01 20:00                 ` Jeff King
2011-03-01 20:12                 ` Junio C Hamano
2011-03-01 20:25                   ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd3maelbh.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=szeder@ira.uka.de \
    --cc=webmaster@hartwork.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).