git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: ab/i18n (What's cooking in git.git (Feb 2011, #05; Wed, 23))
Date: Wed, 23 Feb 2011 17:16:14 -0800	[thread overview]
Message-ID: <7vd3mi44gx.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110223234828.GA7286@elie> (Jonathan Nieder's message of "Wed\, 23 Feb 2011 17\:48\:28 -0600")

Jonathan Nieder <jrnieder@gmail.com> writes:

> The commit message for the second one seems to have been mangled:
>
> 	i18n: add GETTEXT_POISON to simulate translated messages unfriendly translator

Yeah, I think I was fooled by the header folding while fixing things up
inside the mailbox.

> I still don't like the #-sign business in this commit.  Couldn't it
> be split into a separate patch, not to be applied until just before
> the strings in commit/tag/wt-status are marked for translation?

That might be a sensible thing to do.   Ævar what do you think?

> There is also a patch out there to make this use rot13, which I am
> somewhat fond of.  Unfortunately, it leaks (because it is not clear
> how long translated strings are supposed to last).

Yeah I would imagine it would leak.  Also blindly running rot13 to turn %d
into %q is probably not what you want.

> I'd be happy with renaming use_poison() to gettext_poison() or
> similar.  I suppose that is not urgent.

I would prefer to be able to merge the first handful to 'master' sooner
rather than later to minimize the damage to in-flight topics, though.

Thanks.

  reply	other threads:[~2011-02-24  1:16 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-23 23:26 What's cooking in git.git (Feb 2011, #05; Wed, 23) Junio C Hamano
2011-02-23 23:48 ` ab/i18n (What's cooking in git.git (Feb 2011, #05; Wed, 23)) Jonathan Nieder
2011-02-24  1:16   ` Junio C Hamano [this message]
2011-02-24  2:55     ` Ævar Arnfjörð Bjarmason
2011-02-24  3:14       ` Jonathan Nieder
2011-02-24 10:38         ` Ævar Arnfjörð Bjarmason
2011-02-24 10:45           ` Jonathan Nieder
2011-02-24 11:00           ` Jonathan Nieder
2011-02-25 21:48             ` Ævar Arnfjörð Bjarmason
2011-02-26  5:14               ` Jonathan Nieder
2011-02-24  4:00       ` ab/i18n Jonathan Nieder
2011-02-24  9:56   ` ab/i18n (What's cooking in git.git (Feb 2011, #05; Wed, 23)) Erik Faye-Lund
2011-02-24 10:27     ` ab/i18n Jonathan Nieder
2011-02-24 19:11       ` ab/i18n Junio C Hamano
2011-02-24 10:40     ` ab/i18n (What's cooking in git.git (Feb 2011, #05; Wed, 23)) Ævar Arnfjörð Bjarmason
2011-02-23 23:52 ` What's cooking in git.git (Feb 2011, #05; Wed, 23) Johan Herland
2011-02-24  0:43   ` Junio C Hamano
2011-02-24  1:04     ` Johan Herland
2011-02-24  0:32 ` Ævar Arnfjörð Bjarmason
2011-02-24  0:57   ` Junio C Hamano
2011-02-24  1:37     ` Ævar Arnfjörð Bjarmason
2011-02-24  1:59       ` Junio C Hamano
2011-02-24  2:07         ` Ævar Arnfjörð Bjarmason
2011-02-24  9:45   ` Erik Faye-Lund
2011-02-24 17:47     ` Ævar Arnfjörð Bjarmason
2011-02-24 22:39       ` Jonathan Nieder
2011-02-25  1:45       ` [msysGit] " Johannes Schindelin
2011-02-25  9:05     ` Kirill Smelkov
2011-02-25 11:11       ` Johannes Schindelin
2011-02-25 19:24         ` Kirill Smelkov
2011-02-25 21:54           ` Johannes Schindelin
2011-02-26 11:07             ` Kirill Smelkov
2011-02-26 19:07               ` Kirill Smelkov
2011-02-26 19:58                 ` cross-compiling msys-1.0.dll, was " Johannes Schindelin
2011-03-12 13:18                   ` Kirill Smelkov
2011-03-12 15:38                     ` Johannes Schindelin
2011-02-27 14:28               ` Johannes Schindelin
2011-03-12 13:16                 ` Kirill Smelkov
2011-02-26 10:24 ` Adding Beyond Compare as a merge tool, was: " Sebastian Schuberth
2011-02-26 10:33   ` Junio C Hamano
2011-02-26 10:48     ` Sebastian Schuberth
2011-02-27  5:38   ` Chris Packham
2011-02-27  9:09     ` Junio C Hamano
2011-02-27 10:58       ` Sebastian Schuberth
2011-02-27 10:57     ` Sebastian Schuberth
2011-02-27 11:15       ` Sebastian Schuberth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd3mi44gx.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).