From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] xmalloc: include size in the failure message
Date: Fri, 20 Aug 2010 09:31:44 -0700 [thread overview]
Message-ID: <7vd3tdckjz.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1282316991-23320-1-git-send-email-Matthieu.Moy@imag.fr> (Matthieu Moy's message of "Fri\, 20 Aug 2010 17\:09\:51 +0200")
Matthieu Moy <Matthieu.Moy@imag.fr> writes:
>> Under NO_C99_FORMAT the format and the argument would not match if size_t
>> is not the same size as uint. As the one in sha1_file.c seems to be done
>> in a better way, let's use that one.
>
> Sounds good. Not sure why we don't basically use the %lu version
> everywhere though.
I have been wondering about the same thing, but perhaps because we won't
have to worry too much about size_t needing to be unsigned long long on
older platforms where %z is not supported, while we expect %z will be
available on larger where using %lu may become an issue?
prev parent reply other threads:[~2010-08-20 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 13:01 [PATCH] xmalloc: include size in the failure message Matthieu Moy
2010-08-20 14:47 ` Junio C Hamano
2010-08-20 15:09 ` Matthieu Moy
2010-08-20 16:31 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd3tdckjz.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).