From: Junio C Hamano <gitster@pobox.com>
To: Michael Lukashov <michael.lukashov@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 4/4] Refactoring: remove duplicated code from builtin-checkout.c and merge-recursive.c
Date: Tue, 16 Feb 2010 11:41:57 -0800 [thread overview]
Message-ID: <7vd405m0hm.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1266276411-5796-5-git-send-email-michael.lukashov@gmail.com> (Michael Lukashov's message of "Mon\, 15 Feb 2010 23\:26\:50 +0000")
Michael Lukashov <michael.lukashov@gmail.com> writes:
> diff --git a/merge-recursive.c b/merge-recursive.c
> index cb53b01..5999ae2 100644
> --- a/merge-recursive.c
> +++ b/merge-recursive.c
> @@ -599,7 +599,7 @@ struct merge_file_info
> merge:1;
> };
>
> -static void fill_mm(const unsigned char *sha1, mmfile_t *mm)
> +void fill_mm(const unsigned char *sha1, mmfile_t *mm)
> {
> unsigned long size;
> enum object_type type;
Isn't a much better home for this function next to read_mmfile() in
xdiff-interface.c?
Perhaps it would make sense to morph it into something like this
int read_mmblob(mmfile_t *ptr, const unsigned char *sha1);
for consistency.
prev parent reply other threads:[~2010-02-16 19:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 23:26 [PATCH v2 0/4] Refactoring: remove duplicated code Michael Lukashov
2010-02-15 23:26 ` [PATCH v2 1/4] Refactoring: remove duplicated code from builtin-send-pack.c and transport.c Michael Lukashov
2010-02-16 2:16 ` Tay Ray Chuan
2010-02-16 7:29 ` Jeff King
2010-02-15 23:26 ` [PATCH v2 2/4] Refactoring: connect.c: move duplicated code to get_host_and_port Michael Lukashov
2010-02-16 4:10 ` Larry D'Anna
2010-02-15 23:26 ` [PATCH v2 3/4] Refactoring: move duplicated code from builtin-pack-objects.c and fast-import.c to object.c Michael Lukashov
2010-02-16 19:35 ` Junio C Hamano
2010-02-15 23:26 ` [PATCH v2 4/4] Refactoring: remove duplicated code from builtin-checkout.c and merge-recursive.c Michael Lukashov
2010-02-16 19:41 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd405m0hm.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=michael.lukashov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).