From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 5/6] receive-pack: Wrap status reports inside side-band-64k
Date: Fri, 05 Feb 2010 13:14:37 -0800 [thread overview]
Message-ID: <7vd40j1j2a.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1265403462-20572-6-git-send-email-spearce@spearce.org> (Shawn O. Pearce's message of "Fri\, 5 Feb 2010 12\:57\:41 -0800")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> If the client requests the side-band-64k protocol capability we
> now wrap the status report data inside of packets sent to band #1.
> This permits us to later send additional progress or informational
> messages down band #2.
>
> If side-band-64k was enabled, we always send a final flush packet
> to let the client know we are done transmitting.
Two questions.
- Why does use_sideband, the variable with the same name as a boolean
variable used by other parts of the system to decide whether we should
or should not use the sideband communiocation, get a value other than 0
or 1? What is the benefit of using it to keep an actual value? Does
the benefit outweigh the confusion factor?
- What happens if client wants only side-band, not 64k? This is just
theoretical and "we don't bother" is a perfectly acceptable answer. I
am just curious ;-).
next prev parent reply other threads:[~2010-02-05 21:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 20:57 [PATCH v2 0/6] receive-pack hooks over sideband Shawn O. Pearce
2010-02-05 20:57 ` [PATCH v2 1/6] run-command: Allow stderr to be a caller supplied pipe Shawn O. Pearce
2010-02-05 20:57 ` [PATCH v2 2/6] run-command: support custom fd-set in async Shawn O. Pearce
2010-02-05 20:57 ` [PATCH v2 3/6] send-pack: demultiplex a sideband stream with status data Shawn O. Pearce
2010-02-05 20:57 ` [PATCH v2 4/6] receive-pack: Refactor how capabilities are shown to the client Shawn O. Pearce
2010-02-05 20:57 ` [PATCH v2 5/6] receive-pack: Wrap status reports inside side-band-64k Shawn O. Pearce
2010-02-05 21:14 ` Junio C Hamano [this message]
2010-02-05 21:53 ` Shawn O. Pearce
2010-02-05 22:19 ` Junio C Hamano
2010-02-05 20:57 ` [PATCH v2 6/6] receive-pack: Send hook output over side band #2 Shawn O. Pearce
2010-02-09 16:52 ` Larry D'Anna
2010-02-09 17:20 ` Shawn O. Pearce
2010-02-09 17:33 ` Larry D'Anna
2010-02-09 17:41 ` Larry D'Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd40j1j2a.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).