From: Junio C Hamano <gitster@pobox.com>
To: Alex Vandiver <alex@chmrr.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow --quiet option to git remote, particularly for `git remote update`
Date: Sat, 05 Dec 2009 18:04:14 -0800 [thread overview]
Message-ID: <7vd42soo2p.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1260057623-28960-1-git-send-email-alex@chmrr.net> (Alex Vandiver's message of "Sat\, 5 Dec 2009 19\:00\:23 -0500")
Alex Vandiver <alex@chmrr.net> writes:
> Signed-off-by: Alex Vandiver <alex@chmrr.net>
Sounds good as it makes the behaviour consistent with the underlying "git
fetch".
> ...
> "git remote prune [-n | --dry-run] <name>",
> - "git remote [-v | --verbose] update [-p | --prune] [group | remote]",
> + "git remote [-v | --verbose] [-q | --quiet] update [-p | --prune] [group]",
We say "<name>" everywhere else except for "update" we call the parameter
"group" or "remote" using different typography. It is not the fault of
your patch, but has been this way since 1918278 (Allow git-remote to
update named groups of remotes, 2007-02-20).
Three issues to consider:
- shouldn't we use the same typography, i.e. <group>?
- should we say <name> _if_ we are not going to say <group>|<remote>?
- should we keep it as <group>|<remote> to make it clear that only this
subcommand allows the group nickname?
The first two are easy and I expect the answers to be both yes. The third
one needs some studying and further thought.
- is "remote update" the only one that takes group nickname?
- should "remote update" the only one? e.g. does "remote prune" also
take group? if not, shouldn't it?
next prev parent reply other threads:[~2009-12-06 2:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 0:00 [PATCH] Allow --quiet option to git remote, particularly for `git remote update` Alex Vandiver
2009-12-06 2:04 ` Junio C Hamano [this message]
2009-12-07 7:23 ` Alex Vandiver
2009-12-06 14:50 ` Jeff King
2009-12-07 6:15 ` Alex Vandiver
2009-12-07 6:40 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd42soo2p.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=alex@chmrr.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).