From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH 2/2] pack documentation review updates Date: Sun, 15 Nov 2009 01:11:56 -0800 Message-ID: <7vd43kqhib.fsf@alter.siamese.dyndns.org> References: <7v8welbl2p.fsf@alter.siamese.dyndns.org> <20091111171924.6117@nanako3.lavabit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nanako Shiraishi , Junio C Hamano , Sverre Rabbelier , "Shawn O. Pearce" , git list To: Scott Chacon X-From: git-owner@vger.kernel.org Sun Nov 15 10:12:21 2009 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1N9b9g-0002nF-Pr for gcvg-git-2@lo.gmane.org; Sun, 15 Nov 2009 10:12:21 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752416AbZKOJMH (ORCPT ); Sun, 15 Nov 2009 04:12:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752324AbZKOJMH (ORCPT ); Sun, 15 Nov 2009 04:12:07 -0500 Received: from a-pb-sasl-sd.pobox.com ([64.74.157.62]:47423 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbZKOJMF (ORCPT ); Sun, 15 Nov 2009 04:12:05 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 7A6D399214; Sun, 15 Nov 2009 04:12:11 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=to:cc:subject :references:from:date:message-id:mime-version:content-type; s= sasl; bh=ox2l62JdwRvjuTt7hSeq4CZHU+Q=; b=Ubk6towTasqH3cDJS4kf0ge DjRLoVGSBqQNxeJvRM1T1FmA0eY1CbDVDaYZDeqHQftsXt/GsksECmsg6Q8ODE+9 oVCGiWOaEOLI4MlislB3pWhJIClZBbkCKaJk0AGyR6a6C/PFUOP7wu8wqkaqa1gs Yk07C1lURVkow9V/7NG4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=to:cc:subject :references:from:date:message-id:mime-version:content-type; q= dns; s=sasl; b=anNJXnpwz9WPUNiZXLg/cOq5Z2V7wpnb+gOS4unHwMCZCnovZ gz/wBtGAHkeTon10B0nCKJJM3yVgDP+edCBIt4JyE/CyG32xX3Kik5rgPnFKpX1F wsRyY5xk2QuLEJXvLe2DrZq3EAALpAxqJuJ7qK/KYRypecSvvUjQWJn2UI= Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 2D4FD99213; Sun, 15 Nov 2009 04:12:06 -0500 (EST) Received: from pobox.com (unknown [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id 3686999212; Sun, 15 Nov 2009 04:11:57 -0500 (EST) User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) X-Pobox-Relay-ID: F1FEC13E-D1C6-11DE-91A7-EF34BBB5EC2E-77302942!a-pb-sasl-sd.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Scott Chacon writes: > On Wed, Nov 11, 2009 at 9:19 AM, Nanako Shiraishi wrote: >> Update Scott's protocol document according to review comments given by Junio. >> >> * name of "%00" byte is NUL not null; >> ... >> * don't unnecessarily say "SHOULD NOT" when existing servers can satisify >> "MUST NOT"; >> ... > > I was _just_ working on this yesterday and had gotten about halfway > through - I'm traveling a lot right now, so I'm a bit behind. This > looks good, thanks for taking the time Nanako. > > Signed-off-by: Scott Chacon Thanks, both. I had some doubts about the "SHOULD NOT"/"MUST" on obj-id myself, but if you are Ok with the change, I wouldn't complain ;-). Will squash this in.