From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Marius Storm-Olsen <mstormo@gmail.com>,
Johannes Sixt <j.sixt@viscovery.net>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] Add explicit Cygwin check to guard WIN32 header inclusion
Date: Mon, 09 Nov 2009 14:25:09 -0800 [thread overview]
Message-ID: <7vd43rpc8q.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4AF86E0C.4080001@ramsay1.demon.co.uk> (Ramsay Jones's message of "Mon\, 09 Nov 2009 19\:31\:24 +0000")
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> Changes since v2:
> - removed indentation from the #if-#endif block
>
> I hope you don't mind, but I've only sent this patch, rather than
> re-send the whole series. If you would like a complete re-send, just
> let me know.
No, I don't mind "replace only this one out of the four-patch series" at
all as long as what's being replaced is marked clearly enough (which you
did in this case).
But I thought J6t had problems with what this particular patch does, not
how the patch was indented? So I'd wait for more comments and hopefully
an Ack from him before touching this one.
prev parent reply other threads:[~2009-11-09 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 19:31 [PATCH v3 4/4] Add explicit Cygwin check to guard WIN32 header inclusion Ramsay Jones
2009-11-09 22:25 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd43rpc8q.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=mstormo@gmail.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).