From: Junio C Hamano <gitster@pobox.com>
To: Chris Frey <cdfrey@foursquare.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-remote: fix missing .uploadpack usage for show command
Date: Thu, 25 Jun 2009 14:48:48 -0700 [thread overview]
Message-ID: <7vd48s2ddr.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20090625212135.GA28935@foursquare.net> (Chris Frey's message of "Thu\, 25 Jun 2009 17\:21\:35 -0400")
Chris Frey <cdfrey@foursquare.net> writes:
> For users pulling from machines with self compiled git installs,
> in non-PATH locations, they can set the config option
> remote.<name>.uploadpack to set the location of git-upload-pack.
>
> When using 'git remote show <name>', the remote HEAD check
> did not use the uploadpack configuration setting, and would
> not use the configured program.
>
> In builtin-remote.c, the config setting is already loaded
> with the call to remote_get(), so this patch passes that remote
> along to transport_get().
>
> Signed-off-by: Chris Frey <cdfrey@foursquare.net>
> ---
>
> A possibly clearer description...
Thanks, much clearer. Will queue, aiming to eventually merge to 'maint'.
Do you have tests to protect this fix from getting broken in the future by
other people?
prev parent reply other threads:[~2009-06-25 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 9:00 [PATCH] git-remote: fixed missing .uploadpack usage for show command Chris Frey
2009-06-25 18:32 ` Junio C Hamano
2009-06-25 21:21 ` Chris Frey
2009-06-25 21:48 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd48s2ddr.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=cdfrey@foursquare.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).