From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: "Rafael Garcia-Suarez" <rgarciasuarez@gmail.com>,
git@vger.kernel.org,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Toralf Förster" <toralf.foerster@gmx.de>
Subject: Re: [PATCHv2] gitweb: Better regexp for SHA-1 committag match
Date: Fri, 06 Feb 2009 23:48:08 -0800 [thread overview]
Message-ID: <7vd4duzo07.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200902061149.16210.jnareb@gmail.com> (Jakub Narebski's message of "Fri, 6 Feb 2009 11:49:14 +0100")
Jakub Narebski <jnareb@gmail.com> writes:
> Make SHA-1 regexp to be turned into hyperlink (SHA-1 committag)
> to match word boundary at beginning and end. This way we limit
> false matches, for example 0x74a5cd01 which is hex decimal (for
> example memory address) but not SHA-1.
>
> Also make sure that it is not Message-ID, which fragment just
> looks like SHA-1 (e.g. "Message-ID: <46A0F335@example.com>"),
> by using zero-width negative look-ahead assertion to _not_
> match '@' after.
Your message I am responding to is:
Message-ID: <200902061149.16210.jnareb@gmail.com>
Does your description mean that "200902061149" would match, because the
LAA will say "Ah, dot is not an at-sign"?
next prev parent reply other threads:[~2009-02-07 7:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 21:04 webgit highlightes mem adresses as git versions Toralf Förster
2009-02-02 22:54 ` Jakub Narebski
2009-02-03 11:04 ` Toralf Förster
2009-02-03 12:31 ` Johannes Schindelin
2009-02-06 9:12 ` [PATCH] gitweb: Better regexp for SHA-1 committag match Jakub Narebski
2009-02-06 9:49 ` Rafael Garcia-Suarez
2009-02-06 10:26 ` Jakub Narebski
2009-02-06 10:31 ` Rafael Garcia-Suarez
2009-02-06 10:49 ` [PATCHv2] " Jakub Narebski
2009-02-06 13:03 ` Johannes Schindelin
2009-02-06 21:47 ` Jay Soffian
2009-02-06 22:00 ` Jakub Narebski
2009-02-07 7:48 ` Junio C Hamano [this message]
2009-02-07 8:34 ` Jakub Narebski
2009-02-07 8:48 ` Junio C Hamano
2009-02-07 9:25 ` Jakub Narebski
2009-02-07 9:32 ` demerphq
2009-02-07 10:09 ` Jakub Narebski
2009-02-07 14:01 ` Jakub Narebski
2009-02-07 9:22 ` [PATCH] " demerphq
2009-02-07 10:07 ` Jakub Narebski
2009-02-07 13:30 ` demerphq
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4duzo07.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=rgarciasuarez@gmail.com \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).