git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Markus Heidelberg <markus.heidelberg@web.de>, git@vger.kernel.org
Subject: Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote
Date: Sat, 17 Jan 2009 00:03:22 -0800	[thread overview]
Message-ID: <7vd4em8ilx.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090116221203.GP10179@spearce.org> (Shawn O. Pearce's message of "Fri, 16 Jan 2009 14:12:03 -0800")

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Markus Heidelberg <markus.heidelberg@web.de> wrote:
>> 
>> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>
>
>> 	I've just accidently read in the completion file itself, that
>> 	Shawn is the maintainer, so I give it a third try. The first two
>> 	haven't been sent to him.
>
> Sorry, I must have missed the other two attempts.  :-)

And I seem to have missed all three.

>
>  
>>  contrib/completion/git-completion.bash |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
>> index 049ded0..6623344 100755
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -1384,7 +1384,7 @@ _git_config ()
>>  
>>  _git_remote ()
>>  {
>> -	local subcommands="add rm show prune update"
>> +	local subcommands="add rename rm show prune update"
>>  	local subcommand="$(__git_find_subcommand "$subcommands")"
>>  	if [ -z "$subcommand" ]; then
>>  		__gitcomp "$subcommands"
>> @@ -1392,7 +1392,7 @@ _git_remote ()
>>  	fi
>>  
>>  	case "$subcommand" in
>> -	rm|show|prune)
>> +	rename|rm|show|prune)
>>  		__gitcomp "$(__git_remotes)"
>>  		;;
>>  	update)
>> -- 
>> 1.6.1.35.g0c23
>> 
>
> -- 
> Shawn.
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-01-17  8:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200901162254.58300.markus.heidelberg@web.de>
2009-01-16 22:12 ` [PATCH resend] bash completion: add 'rename' subcommand to git-remote Shawn O. Pearce
2009-01-17  8:03   ` Junio C Hamano [this message]
2009-01-20 18:21     ` Markus Heidelberg
2009-01-21 10:26       ` Junio C Hamano
2009-01-21 22:59         ` Markus Heidelberg
2009-01-08 18:53 [PATCH, " Markus Heidelberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd4em8ilx.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=markus.heidelberg@web.de \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).