From: Junio C Hamano <gitster@pobox.com>
To: Yann Dirson <ydirson@altern.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] Introduce rename factorization in diffcore.
Date: Fri, 07 Nov 2008 16:47:46 -0800 [thread overview]
Message-ID: <7vd4h7dowd.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081108002952.GC4030@nan92-1-81-57-214-146.fbx.proxad.net> (Yann Dirson's message of "Sat, 8 Nov 2008 01:29:52 +0100")
Yann Dirson <ydirson@altern.org> writes:
> ... Commands
> for saving/mailing patches could issue a bold warning if the user
> specifies the for-human-viewing flag.
If it is a warning to the user who produces the patch, and not but a
warning in the patch text for the user who receives it, it is not useful.
> I was talking about exchanging patches with the non-git part of the
> world.
Renaming patch needs manual massaging if you want to use GNU patch and
that is not a new issue. People know that.
The problem is in your example output were that it would break _existing
git tools_ with a backward incompatible change, when you did not have to.
That's the difference.
next prev parent reply other threads:[~2008-11-08 0:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 22:03 [PATCH v3 0/3] Detection of directory renames Yann Dirson
2008-11-01 22:03 ` [PATCH 1/3] Fix error in diff_filepair::status documentation Yann Dirson
2008-11-02 6:31 ` Junio C Hamano
2008-11-01 22:03 ` [PATCH 2/3] Introduce rename factorization in diffcore Yann Dirson
2008-11-07 1:10 ` Junio C Hamano
2008-11-07 19:39 ` Yann Dirson
2008-11-07 20:19 ` Junio C Hamano
2008-11-07 20:39 ` Yann Dirson
2008-11-07 21:11 ` Junio C Hamano
2008-11-07 22:12 ` Yann Dirson
2008-11-07 23:43 ` Junio C Hamano
2008-11-08 0:29 ` Yann Dirson
2008-11-08 0:47 ` Junio C Hamano [this message]
2008-11-08 0:50 ` Yann Dirson
2008-11-01 22:03 ` [PATCH 3/3] Add testcases for the --factorize-renames diffcore flag Yann Dirson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4h7dowd.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).