From: Junio C Hamano <gitster@pobox.com>
To: Heikki Orsila <heikki.orsila@iki.fi>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add --filedirstat diff option
Date: Mon, 01 Sep 2008 23:57:46 -0700 [thread overview]
Message-ID: <7vd4jnnifp.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080901011259.GA31696@zakalwe.fi> (Heikki Orsila's message of "Mon, 1 Sep 2008 04:12:59 +0300")
Heikki Orsila <heikki.orsila@iki.fi> writes:
> @@ -2474,7 +2478,10 @@ int diff_opt_parse(struct diff_options *options, const char **av, int ac)
> options->output_format |= DIFF_FORMAT_DIRSTAT;
> else if (!strcmp(arg, "--cumulative"))
> options->output_format |= DIFF_FORMAT_CUMULATIVE;
> - else if (!strcmp(arg, "--check"))
> + else if (opt_arg(arg, 'X', "filedirstat", &options->dirstat_percent)) {
> + options->output_format |= DIFF_FORMAT_DIRSTAT;
> + options->filedirstat = 1;
Why 'X'? It would never match, confusing to the reader, and risks a
sudden change in behaviour when these statements are reordered or somebody
mechanically attempts to convert this to parse_options().
next prev parent reply other threads:[~2008-09-02 7:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 1:12 [PATCH] Add --filedirstat diff option Heikki Orsila
2008-09-02 6:57 ` Junio C Hamano [this message]
2008-09-02 11:58 ` Heikki Orsila
2008-09-02 23:40 ` Junio C Hamano
2008-09-02 23:55 ` Junio C Hamano
2008-09-03 0:08 ` Heikki Orsila
2008-09-03 0:28 ` Re* " Junio C Hamano
2008-09-03 0:39 ` Heikki Orsila
2008-09-03 0:12 ` Jeff King
2008-09-03 0:18 ` Heikki Orsila
2008-09-03 0:44 ` Junio C Hamano
2008-09-03 12:47 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2008-09-02 23:51 Heikki Orsila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4jnnifp.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=heikki.orsila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).