git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Marcus Griep <marcus@griep.us>
Cc: Git Mailing List <git@vger.kernel.org>,
	"Marius Storm-Olsen" <mstormo_git@storm-olsen.com>
Subject: Re: [PATCH] git-commit: '--no-status' Allow suppression of status summary in commit msg
Date: Thu, 28 Aug 2008 12:09:35 -0700	[thread overview]
Message-ID: <7vd4jtdki8.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1219949215-10189-1-git-send-email-marcus@griep.us> (Marcus Griep's message of "Thu, 28 Aug 2008 14:46:55 -0400")

Marcus Griep <marcus@griep.us> writes:

> Currently, using any editor to edit a commit message for 'git commit'
> kicks of a 'git status' which is then included as comments to give
> the commit author some context. However, in some situations, such as
> having a working tree of many hundred thousand files or on an inefficient
> filesystem,

I am not interested in this particular patch, especially the part that
hoards a short-and-nice -S flag that we could use for something more
useful.  Also calling the configuration variable "nostatus" is backwards;
I'd name it to "showstatus" that defaults to "true" if I were doing this.

You did not mention exactly how the "hundred thousand files on an
inefficient filesystem" is a problem, but if it is about listing untracked
files, I thought Marius Storm-Olsen added a feature to address that with
4bfee30 (Add an optional <mode> argument to commit/status -u|--untracked-files
option, 2008-06-05).

If that is not still enough for your particular use case, I think you can
have a custom wrapper that does:

	#!/bin/sh
	: >.log-message-file &&
        vi .log-message-file &&
        git commit -F .log-message-file "$@" &&
        rm -f .log-message-file 

without touching git at all.

  reply	other threads:[~2008-08-28 19:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-28 18:46 [PATCH] git-commit: '--no-status' Allow suppression of status summary in commit msg Marcus Griep
2008-08-28 19:09 ` Junio C Hamano [this message]
2008-08-28 19:34   ` Alex Riesen
2008-08-28 19:13 ` Alex Riesen
2008-08-28 19:24   ` Marcus Griep
2008-08-29  5:39     ` Marius Storm-Olsen
2008-08-29  5:49       ` Marius Storm-Olsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd4jtdki8.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=marcus@griep.us \
    --cc=mstormo_git@storm-olsen.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).