Re: What's cooking in git.git (Aug 2008, #07; Sat, 23)

[Junio C Hamano <gitster@pobox.com>]

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> * sb/daemon (Thu Aug 14 20:02:20 2008 +0200) 4 commits
>>  - git-daemon: rewrite kindergarden, new option --max-connections
>>  - git-daemon: Simplify dead-children reaping logic
>>  - git-daemon: use LOG_PID, simplify logging code
>>  - git-daemon: call logerror() instead of error()
>> 
>> Can somebody who actually runs the daemon standalone comment on this 
>> one?
>
> I am somewhat uneasy about running my production machine with these 
> changes, since the last commit (the one introducing a kindergarden with 
> cradles) is too unobvious for me.

Well, I didn't ask anybody to _run_ it.

I asked people who care about their daemons to comment on the change, so
that if there are any issues in the code that I didn't see, the breakage
gets caught before it propagates to their daemons they build from 'next'
or 'master'.

Having said that, I do agree that the kindergarden change is very involved
(it removes more code than it adds --- the reduction of lines is somewhat
inflated because quite a lot of comments that have become stale gets
removed by the patch).