* [PATCH] git-p4: Fix one-liner in p4_write_pipe function.
@ 2008-08-21 21:11 Tor Arvid Lund
2008-08-22 6:21 ` Junio C Hamano
2008-08-25 20:41 ` Anand Kumria
0 siblings, 2 replies; 4+ messages in thread
From: Tor Arvid Lund @ 2008-08-21 21:11 UTC (permalink / raw)
To: git, Simon Hausmann, Junio C Hamano; +Cc: Tor Arvid Lund
The function built a p4 command string via the p4_build_cmd function, but
ignored the result.
---
contrib/fast-import/git-p4 | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index f9865b4..46136d4 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -76,7 +76,7 @@ def write_pipe(c, str):
def p4_write_pipe(c, str):
real_cmd = p4_build_cmd(c)
- return write_pipe(c, str)
+ return write_pipe(real_cmd, str)
def read_pipe(c, ignore_error=False):
if verbose:
--
1.6.0.GIT
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] git-p4: Fix one-liner in p4_write_pipe function.
2008-08-21 21:11 [PATCH] git-p4: Fix one-liner in p4_write_pipe function Tor Arvid Lund
@ 2008-08-22 6:21 ` Junio C Hamano
2008-08-22 7:23 ` Tor Arvid Lund
2008-08-25 20:41 ` Anand Kumria
1 sibling, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2008-08-22 6:21 UTC (permalink / raw)
To: Tor Arvid Lund; +Cc: git, Simon Hausmann
Looks obviously correct. Mind if I forge your sign-off?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git-p4: Fix one-liner in p4_write_pipe function.
2008-08-22 6:21 ` Junio C Hamano
@ 2008-08-22 7:23 ` Tor Arvid Lund
0 siblings, 0 replies; 4+ messages in thread
From: Tor Arvid Lund @ 2008-08-22 7:23 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Simon Hausmann
On Fri, Aug 22, 2008 at 8:21 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Looks obviously correct. Mind if I forge your sign-off?
>
Heh, that'll be fine. I don't submit patches that often, so I just
forgot - sorry ;-)
-Tor Arvid-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git-p4: Fix one-liner in p4_write_pipe function.
2008-08-21 21:11 [PATCH] git-p4: Fix one-liner in p4_write_pipe function Tor Arvid Lund
2008-08-22 6:21 ` Junio C Hamano
@ 2008-08-25 20:41 ` Anand Kumria
1 sibling, 0 replies; 4+ messages in thread
From: Anand Kumria @ 2008-08-25 20:41 UTC (permalink / raw)
To: git
On Thu, 21 Aug 2008 23:11:40 +0200, Tor Arvid Lund wrote:
> The function built a p4 command string via the p4_build_cmd function,
> but ignored the result.
Opps - thanks for catching this.
Anand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-08-25 20:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-21 21:11 [PATCH] git-p4: Fix one-liner in p4_write_pipe function Tor Arvid Lund
2008-08-22 6:21 ` Junio C Hamano
2008-08-22 7:23 ` Tor Arvid Lund
2008-08-25 20:41 ` Anand Kumria
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).