From: Junio C Hamano <gitster@pobox.com>
To: Christian Jaeger <christian@jaeger.mine.nu>
Cc: git@vger.kernel.org, Gerrit Pape <pape@smarden.org>
Subject: Re: GIT-VERSION-GEN gives "-dirty" when file metadata changed
Date: Thu, 07 Aug 2008 14:48:06 -0700 [thread overview]
Message-ID: <7vd4kkijjd.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <sjj6zt28jy9qy7y8@jaeger.mine.nu> (Christian Jaeger's message of "Thu, 07 Aug 2008 21:35:17 +0200")
Christian Jaeger <christian@jaeger.mine.nu> writes:
> Today I've created custom Debian packages from Git for the first time (yes I know there are Debian packages already, I'm doing it so that I can patch Git and still have the convenience of a package system),
I personally think that _you_ are responsible for doing the refresh
yourself after becoming root, if you checkout as yourself and then build
as root (or use fakeroot to build as if it is built as root).
By the way "man fakeroot" says...
-u, --unknown-is-real
Use the real ownership of files previously unknown to fakeroot
instead of pretending they are owned by root:root.
which sounds like a sensible thing to do (I would even imagine that would
be a sensible default for fakeroot in general), and I would imagine that
would help.
Not that an extra update-index --refresh would be a huge performance hit,
but I hesitate to take a patch that adds something that should
conceptually be unnecessary.
next prev parent reply other threads:[~2008-08-07 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 19:35 GIT-VERSION-GEN gives "-dirty" when file metadata changed Christian Jaeger
2008-08-07 15:16 ` [PATCH A] GIT-VERSION-GEN: refresh the index before judging a working dir to be dirty Christian Jaeger
2008-08-07 17:59 ` [PATCH B] " Christian Jaeger
2008-08-07 21:48 ` Junio C Hamano [this message]
2008-08-08 8:55 ` GIT-VERSION-GEN gives "-dirty" when file metadata changed Christian Jaeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4kkijjd.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=christian@jaeger.mine.nu \
--cc=git@vger.kernel.org \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).