From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] bisect: use "$GIT_DIR/BISECT_START" to check if we are bisecting
Date: Wed, 28 May 2008 21:28:24 -0700 [thread overview]
Message-ID: <7vd4n5raxj.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200805290601.19067.chriscool@tuxfamily.org> (Christian Couder's message of "Thu, 29 May 2008 06:01:18 +0200")
Christian Couder <chriscool@tuxfamily.org> writes:
>> The reason you ignore an existing but empty BISECT_START file is...?
>
> ... that it should not happen, because this file is only written
> in "bisect_start" and there its content comes either from the current HEAD
> or from a previous not empty BISECT_START file.
>
> We might add a check for an empty BISECT_START file and warn in this case
> that the file may have been corrupted, but that may be for another patch.
My question was more about "why are you acting as if distinction between
empty and nonempty BISECT_START matters?"
Because you "echo $start_head >$GIT_DIR/BISECT_START", this file will
always at least have a terminating LF even when the head is detached.
IOW, if it exists, it will never be empty, I think.
prev parent reply other threads:[~2008-05-29 4:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 16:57 [PATCH] bisect: use "$GIT_DIR/BISECT_START" to check if we are bisecting Christian Couder
2008-05-28 17:04 ` Junio C Hamano
2008-05-29 4:01 ` Christian Couder
2008-05-29 4:28 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4n5raxj.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).